Page MenuHomePhabricator

Use of edit token in ApiModifyItem
Closed, ResolvedPublic

Description

To make the API somewhat simpler, and possibly easier to maintain, the itemtoken should be removed in favor of the edittoken. The only real problem is that we can't change it to enforce serialization of some of the requests, but those calls could be handled separately.

Use of "gettoken" will be removed from wbgetitems and wbset*. All modules that use "token" will then supply edittoken and not itemtoken. The user interface is currently using edittoken and can continue to use that one. For API calls the edittoken is already available through action=tokens, and no changes are necessary there.

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=35993


Version: unspecified
Severity: normal

Details

Reference
bz39366

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:50 AM
bzimport set Reference to bz39366.
bzimport added a subscriber: Unknown Object (MLST).

Local change in work, kill-gettoken-39366, not ready for review

Change I7cee30ea: Kill use of gettoken

When I tried to change the tests into using the edittoken (the UI already does that) I got a lot of failures and they seems to emerge from a session failure. There are some print statements in there that needs to be removed when the patchset works.

Verified in Wikidata demo time for sprint 17