Page MenuHomePhabricator

Language-Links are not updated on client when corresponding links are removed from the repo unless you do a purge
Closed, ResolvedPublic

Description

Reproduce the bug:

  • Create an article "London" on the client
  • Create an item "London" in the repo
  • Add an english language link to the item to connect this item to the article
  • Add further language-links e.g. de, it, nl and fr to the item
  • The language links are now shown correctly on the client
  • If you remove one or more of the language-links (except the ENGLISH one) from the repo or add further links, the corresponding links on the client are updated as they should
  • BUT: if you remove the ENGLISH language link plus some of the others, then the links are not updated anymore on the client and they are displayed until you do a purge on the client

Version: unspecified
Severity: blocker
Whiteboard: storypoints: 5

Details

Reference
bz39384

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:51 AM
bzimport set Reference to bz39384.
bzimport added a subscriber: Unknown Object (MLST).

A page being unlinked does not get notified.

When the sitelink to the client is being changed, purge both the old and the new target page.

onWikiBasePollHandle could be doing this.

This doesn't seem fixed to me.

  • I removed a link to [[it:Esecutore testamentario]] from an otherwise empty Wikidata entry.
  • I added a link to it on [[d:Q654437]].
  • 8 hours later, the it.wiki article didn't have any language link and I had to purge it. The other articles still don't have it.

I don't know if this report is the right one but reopening to avoid forgetting.

@Nemo: that would be because of https://bugzilla.wikimedia.org/45892

there are issues with the change dispatching, which we are working on resolving (some patches in gerrit already).

a manual purge should make the links show up right away, as the rendering of the links does not rely on the change dispatching.

the change dispatching just does the automatic purging, etc. of course, manual purge should not be required.

Highest report on bug 45892 is 8–10 h delay, we're at 9 h for my example (with job queue basically zero, for what it's worth). Now the links appeared on some of the other languages but not all, but it may be someone destroying testcase with manual purges; few more hours of time will tell if it's this bug, bug 45839 or bug 45892. :)

@Nemo: I have confirmed that some of my wikidata edits never showed up in my watchlist. We are reworking the way the dispatchers does stuff.

We are also adding a special page that allows non-shell people (like us, and wikimedians) to know the status/backlog size, and then we can adjust stuff more, as needed.

If it still happens, reopen. It seems fine now.