If we decide to implement this feature right away, we may want to consider only disabling feedback for anons, so that registered users can still post and so that editors can still access the feedback that's been left already -- some of which may be valuable.

So the checkbox would read 'Disable article feedack for anonymous users.'

Otherwise, all access to any feedback features would be completely disabled for editors and registered users, which seems excessive. Our analysis suggests that inappropriate feedback comes largely from anons, not logged-in users.

If we want maximum flexibility and have enough development time, we could use a drop-down menu to give editors all the options they want with this conditional checkbox instead:

'Enable article feedback for [everyone (default) | confirmed editors | administrators]'

By default, the drop-down menu would be set to everyone.

Pushed to Gerrit (https://gerrit.wikimedia.org/r/#/c/20899/) & prototype.

See example at http://prototype.wikimedia.org/rc-en/index.php?title=Golden-crowned_Sparrow&action=protect

Thanks, Matthias!

I love that you have developed so quickly a user interface that is so similar to the Protect page UI ! That said, I agree with Oliver's concerns, and would recommend that we use different language and functions for the three options, as I had proposed on Bugzilla:

"Article feedback:

• Enable for all users
• Enable for registered users only
• Enable for editors only"

I am not a fan of disabling AFT completely, because it is intended as a persistent way to give users a voice -- and that feedback doesn't impact the articles themselves, which makes it a much, much lower risk for Wikipedia. We also have easy ways to flag or hide inappropriate feedback, so this proposed method through 'Protect' should be viewed as a last resort, not a routine operation.

If the whole team thinks we have to give admins the option to disable AFT completely, then it would be possible to add 'Disable' as a fourth option. My advice is to wait a bit before crossing that line.

FYI, I broke my vow of silence during my vacation because this is an important feature that is likely to be implemented this week. But will aim to keep quiet until I return ;o)

Over and out until next week.

-f

The different 3 (non-standard) options turned out to be a 300+ lines of code difference and a config change :) However, this change has also kick-started https://bugzilla.wikimedia.org/show_bug.cgi?id=39497

Anyway, the patch has been updated (https://gerrit.wikimedia.org/r/#/c/20899/ & https://gerrit.wikimedia.org/r/#/c/21141/) & prototype has been updated. Ready for testing at http://prototype.wikimedia.org/rc-en/index.php?title=Golden-crowned_Sparrow&action=protect

Only necessary change in my mind is to make it a fixed thing. There should be a "disable the Article Feedback Tool" checkbox; if you've enabled semi-protection, it should disable for everyone except autoconfirmed editors. If you've enabled full-protection, it should disable for everyone except admins. But we should keep the standards set by the community and also not allow people to (for example) turn the tool off while allowing anyone to edit just because they don't like it.

Everything else looks good.

Update:

Rather than adding a checkbox to make it possible to fully protect a page, a 4th option "Enable for administrators only" has been added in.
The checkbox would've been confusing: when checked, it overrules the dropdown's selection, based on the selection of yet another dropdown. Now the exact selection can be done via the dropdown.

Keeping Fabrice's concern about people completely disabling AFT, we made it impossible to set the protection level of AFT higher than the protection level of editing a page. AFT can only be disabled when a page is being protected.

The copy of the 4 options has changed a bit as well:

• Enable for all users
• Enable for logged-in users only
• Enable for autoconfirmed users only
• Enable for administrators only

This because of the confusion generated by the term "editors" (also see https://bugzilla.wikimedia.org/show_bug.cgi?id=39497#c1)

The changes are pushed to Gerrit & prototype.
Ready for testing at http://prototype.wikimedia.org/rc-en/index.php?title=Golden-crowned_Sparrow&action=protect

Thanks for this great work, Matthias :).

Yes, nicely done! It was a real pleasure to come back from vacation and see that you guys figured it all out in such an elegant way. Much appreciated.