Page MenuHomePhabricator

Hashable should use SHA-1 and not MD5
Closed, ResolvedPublic

Description

To avoid later problems the hashable clash should use SHA-1 and not MD5. The later has weaker properties, but is probably good enough. Still SHA-1 is now used for hashing revisions and it could be better to use the same algorithm.


Version: unspecified
Severity: normal
Whiteboard: storypoints: 2

Details

Reference
bz39506

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:59 AM
bzimport set Reference to bz39506.
bzimport added a subscriber: Unknown Object (MLST).

This shift should be done before anything goes into production. It has implications on SnakObject (line 27), ClaimObject (line 100), MapValueHasher (line 57) and StatementObject (line 185).

Verified in Wikidata demo time for sprint 17