Page MenuHomePhabricator
Create Task
Maniphest T41513

LQT notification email (enotif) are sent for replies/new threads on watchlisted pages/threads regardless of users' enotif settings
Open, MediumPublicBUG REPORT
Actions

Description

Steps to reproduce: see URL.
After setting

$wgDefaultUserOptions['lqtnotifytalk'] = true; [1]

on translatewiki.net, a user will receive email notifications for new threads or replies to threads if the thread is watched (that is, in LQT jargon, if it's individually watchlisted or its parent [talk] page is), regardless of their email notification settings, i.e. even if one or both of "E-mail me when a page or file on my watchlist is changed" and "E-mail me on replies to a thread I am watching" are disabled.
The only workaround is to unwatch both the page and the thread.

[1] https://gerrit.wikimedia.org/r/gitweb?p=translatewiki.git;a=blobdiff;f=TranslatewikiSettings.php;h=85babbfca49e6b12570e79f168a7b8f82da160dc;hp=2f13474494db6de7fbe70ca4547441892ec2f0e6;hb=f800719f61114db1f5fb54425cae100acec89365;hpb=be5777692bc4db94381600e6cc9e98d1fd9ff6c8

Version: master
Severity: major
URL: https://translatewiki.net/wiki/Thread:Talk:Sandbox/Test_enotif

Details

Reference
bz39513

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT14884 Login and account creation should be by secure http.
 InvalidNoneT11816 Improve security for Special:Userlogin (tracking)
 OpenNoneT125653 Create new types of notifications
 OpenFeatureNoneT5234 Extend edit-user-talk notification to include edits to subpages of a user's talk page
 DuplicateNoneT21248 Hotwatch: User_talk-style banner notifications for select article changes
 ResolvedNoneT29829 welcome users without relying on additions to talk page
 DeclinedQuiddityT22541 Watchlist, LiquidThreads and Echo notifications need to be unified
 ResolvedGalorefitzT31856 Email notification to old address when verified email address is changed or removed
 DeclinedNoneT13636 Allowing watchlist notifications if the watchlist is smaller than a certain size
 OpenFeatureNoneT31857 Welcome back email notification after renewed account activity
 OpenFeatureNoneT49000 Preference "Email me on replies to a thread I am watching" is false by default
 InvalidWikinautT3932 [DO NOT USE] ENotif/EConfirm & further enhancements (tracking) [superseded by #MediaWiki-Email]
 Resolved• demonT11838 Send notification to account owner on multiple unsuccessful login attempts
 ResolvedkostajhT34281 MediaWiki needs a sane notification system (tracking)
 OpenBUG REPORTNoneT41513 LQT notification email (enotif) are sent for replies/new threads on watchlisted pages/threads regardless of users' enotif settings
 ResolvedkaldariT140167 Security Review of LoginNotify extension
 Resolved• NiharikaT153335 Investigation: Notify on multiple unsuccessful login attempts
 Resolved• NiharikaT154064 Investigation: What would be the best way to support loginwiki from LoginNotify
 ResolvedBawolffT151414 LoginNotify cleanup
 ResolvedBawolffT135270 Update LoginNotify for AuthManager
 DeclinedNoneT156421 Disable login on loginwiki
 ResolvedkaldariT158871 Enable editmyoptions right for all users on loginwiki
 Resolved• NiharikaT158878 Test LoginNotify Extension on Beta Cluster
 ResolvedMusikAnimalT160031 Improve failed login notifications in LoginNotify extension
 Resolved• NiharikaT160094 Investigation: Config settings for LoginNotify in production
Restricted Task
 Resolved• NiharikaT162104 Fix multiple/repetitive notifications with LoginNotify
 ResolvedReedyT162103 Create a vagrant role for installing LoginNotify with vagrant
 ResolvedMaxSemT165007 Deploy LoginNotify to Test Wikipedia
 ResolvedJohanT165037 Document multiple unsuccessful login attempts notifications
 OpenNoneT182867 BotPasswords + Toolforge combination causing daily "login from new device" warning emails

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:00 AM
• bzimport added a project: MediaWiki-extensions-LiquidThreads.
• bzimport set Reference to bz39513.
• bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Aug 20 2012, 8:33 PM
Nemo_bis added a comment.Aug 20 2012, 8:38 PM

Link to the change: http://ur1.ca/9zvc3

Krenair added a comment.Feb 18 2013, 6:33 PM

Gerrit change 49701

Krenair added a comment.Feb 24 2013, 2:23 PM

Merged by Siebrand.

• bzimport added a comment.Apr 9 2013, 8:21 AM

bugzilla wrote:

Is this bugfix only supposed to work with the latest MW version?

I tested it on MW 1.19.2 and I still get email notifications if a new reply is posted - under the following circumstances:

  • I watch the thread.
  • I have enabled "E-mail me when a page on my watchlist is changed".
  • I have disabled "Email me on replies to a thread I am watching".

As I understand I shouldn't receive email notifications with this configuration...

Nemo_bis added a comment.Nov 12 2013, 4:07 PM

Reopening: after gerrit change 58056, again I verified that I'll receive enotif for a thread I watchlisted (e.g. because of creating it) or for a thread on a page I watchlisted, even with "Email me on replies to a thread I am watching" and "Email me when a page or file on my watchlist is changed" both disabled.

Qgil added a comment.Mar 12 2014, 2:15 PM

Is the importance of this report properly assessed?

Critical Crashes, loss of data (internally, not your edit preview!) in a widely used and important component.

Also, is someone planning on working on it in the next six months?

high Not the next task, but should be fixed soon. Depending on teams & manpower this can take between one and six months.

Nemo_bis added a comment.Mar 12 2014, 2:23 PM

(In reply to Quim Gil from comment #6)

Is the importance of this report properly assessed?

Yes. Critical bugs are typically fixed in 1-5 years for LQT.

Aklapper added a comment.May 19 2014, 7:47 PM

This is not about "Crashes, loss of data"; decreasing severity

• werdna unsubscribed.Dec 10 2014, 5:14 PM
Nemo_bis added a project: MediaWiki-Email.Jan 4 2015, 6:57 PM
Nemo_bis set Security to None.
Jdforrester-WMF lowered the priority of this task from High to Lowest.Aug 4 2016, 11:34 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to High.Aug 5 2016, 7:34 AM
Qgil unsubscribed.Aug 8 2016, 8:10 AM
Liuxinyu970226 lowered the priority of this task from High to Lowest.Mar 22 2019, 2:08 AM
Liuxinyu970226 subscribed.

Still no Gerrit patch to fix this, hence Lowest again, feel free to revert my action with uploading a Gerrit patch

Nemo_bis raised the priority of this task from Lowest to Medium.Mar 22 2019, 1:08 PM
• Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM
• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 15 2022, 9:39 PM
Aklapper removed a subscriber: • wikibugs-l-list.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL