Page MenuHomePhabricator

Very recent update broken critical local infrastructure on English Wikinews
Closed, ResolvedPublic

Description

Author: brian.mcneil

Description:
Image of how recent updates break vital reviewing tool

Sometime after 1800 UTC today, an update was applied to the software which has broken vitally important local functionality on English Wikinews, and - presumably, any other language versions of Wikinews which make use of the same tools.

  1. EzPR.

This is a Gadget which is in-use to carry out independent peer-review on articles submitted for publication. It allows a great deal of data input, writes out the review results on the talk page of the article, and can carry out the multiple steps required to publish an article.

The form simply cannot be input, and a screenshot shows how it is currently displayed.

  1. Our WN:MAKELEAD tool is also broken.

This usually allows easy maintenance of the lead articles displayed on the main page.

Without access to these gadgets, only a small subset of contributors know enough of the technical steps carried out by these tools to process articles submitted for review and maintain the leads on the main page.

This is a critical problem for, at least, English Wikinews (but, what's being tried looks purty).


Version: wmf-deployment
Severity: critical

Attached:

Broken-EzPR.png (668×1 px, 197 KB)

Details

Reference
bz39572

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:04 AM
bzimport set Reference to bz39572.
bzimport added a subscriber: Unknown Object (MLST).

We're looking into this now. We think this might have been caused by the upgrade to jQuery 1.8.0 and jQuery UI 1.18.23 (which was part of 1.20wmf10). It looks like Roan is going to try reverting to the previous versions (jQuery 1.7.2 and jQuery UI 1.18.22, iirc).

brian.mcneil wrote:

Bawolff has made amendments to the EZPR gadget to not use jsMSG, and WN:MAKELEAD appears to offer save options again.

Still getting a few pop-ups that're new (and I'm not complaining about) Eg [[Category:Review]], at least for reviewers, pops up a list of what needs dealt with.

From Roan on IRC at 21:40 UTC: "OK revert is deployed, might take 5-10 minutes to propagate" (referring to the jQuery revert)

(In reply to comment #1)

We're looking into this now. We think this might have been caused by the
upgrade to jQuery 1.8.0 and jQuery UI 1.18.23 (which was part of 1.20wmf10).
It looks like Roan is going to try reverting to the previous versions (jQuery
1.7.2 and jQuery UI 1.18.22, iirc).

It isn't the jQuery update, its caused by Daniel's new notification system [1], and me abusing jsMsg for purposes other than what its original documented use was, back in the day.

Sorry, I should have been on top of that more, I was aware the new system was coming, and aware that it would break the WN gadget I wrote way back

[1] http://lists.wikimedia.org/pipermail/wikitech-l/2012-August/062297.html

(In reply to comment #4)

(In reply to comment #1)

We're looking into this now. We think this might have been caused by the
upgrade to jQuery 1.8.0 and jQuery UI 1.18.23 (which was part of 1.20wmf10).
It looks like Roan is going to try reverting to the previous versions (jQuery
1.7.2 and jQuery UI 1.18.22, iirc).

It isn't the jQuery update, its caused by Daniel's new notification system [1],
and me abusing jsMsg for purposes other than what its original documented use
was, back in the day.

Sorry, I should have been on top of that more, I was aware the new system was
coming, and aware that it would break the WN gadget I wrote way back

[1] http://lists.wikimedia.org/pipermail/wikitech-l/2012-August/062297.html

Err, I meant only for EzPR. The ML issue could very well be the jQuery thing.

What's the status of this bug? What are the issues still unsolved and what are the exact symptoms and error messages?

Hmmm...

For now till we think of how to deal with a small legacy of large messages how about using mw.util.$content.prepend( ... ); instead of jsMessage so that boxes like that just show up at the top of the content area instead of in a message bubble.

A secondary problem has been brought to my attention:

When an article passes review, a message appears providing a link to MakeLead, as it is assumed most articles will be used as leads. This message now appears only for a few seconds before vanishing.

It's been suggested to me this is/was intended as a feature.

sumanah wrote:

Brian and Iain:

Is the original EzPR & WN:MAKELEAD issue (from the original bug report) fixed? If so, please go ahead and close this bug. Iain, if there's a separate MakeLead issue that's still happening, please close this bug report and file a new one that's specifically about that. Thanks!

(In reply to comment #9)

Brian and Iain:

Is the original EzPR & WN:MAKELEAD issue (from the original bug report)
fixed?
If so, please go ahead and close this bug. Iain, if there's a separate
MakeLead issue that's still happening, please close this bug report and file
a
new one that's specifically about that. Thanks!

I believe so. closing as fixed. As always, if there is further issues please re-open or come find me.