Page MenuHomePhabricator

Toolbar shouldn't appear in view source if page is protected
Closed, ResolvedPublic

Description

Looking in view source mode on a protected page for user who isn't allowed to edit the page shouldn't show toolbar.

Moreover the toolbar even inserts code to the textarea on click...

You can try it in [[en:Main page]] edit (for most users [=non admins there]).

When setting off the enhanced toolbar and trying it again, instead of the "regular" toolbar a message appears ("You can view and copy the source of this page")

(maybe the wikieditor shouldn't be loaded at all in "view source" mode)


Version: unspecified
Severity: normal

Details

Reference
bz39577

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:04 AM
bzimport added a project: WikiEditor.
bzimport set Reference to bz39577.
bzimport added a subscriber: Unknown Object (MLST).

Only reproducible on en.wikipedia. The function initializeRefTools from [[MediaWiki:Common.js/edit.js]] might be the culprit, since it loads ext.wikiEditor.toolbar unconditionally.

  • Bug 44079 has been marked as a duplicate of this bug. ***