If page
http://hr.wikiquote.org/wiki/MediaWiki:Previewnote
contains image, it is wrongly parsed somewhere and instead of image, output is rendered as broken HTML.
When you save image it is rendered right (on MediaWiki:Previewnote page), but when this message is shown above preview of every page any user edits, it's broken.
1.20wmf10
Version: 1.20.x
Severity: critical
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T41515 MediaWiki bugs to be fixed for 1.20wmf10 deployment (tracking) | |||
| Resolved | None | T41584 [Regression] MediaWiki:Previewnote broken (double html escaped) |
Ruslik00 wrote:
This message is escaped after it is parsed. This does not seem to be logical.
It's double parsed. Regression in Ifa80db1d81b9b9d1a5adfcac06a9ed14203c100e, should use ->plain() to avoid double parsing.
rd232 wrote:
So we have a fix for a critical bug, but no-one can be found to deploy it?? Go to (random image) http://commons.wikimedia.org/w/index.php?title=File:Page_from_the_Wenzel_Bible.jpg&action=submit&uselang=en and then tell me this is not urgent!
The fix is written, reviewed and merged into MediaWiki core.
In order to deploy it right now it has to be backported to the 1.20wmf10 branch, this can be done by anyone with a Gerrit account (no deployment access needed). Then a deployer will approve it and push it live right away.
(In reply to comment #7)
In order to deploy it right now it has to be backported to the 1.20wmf10
branch, this can be done by anyone with a Gerrit account (no deployment access
needed). Then a deployer will approve it and push it live right away.
Done that in Gerrit change 21730
Marking as fixed. Not sure what's wrong with the backport to 1.20wmf10, could be a nasty dependency. Anyway, it'll be deployed automatically during the next branch point 1.20wmf11 since it is fixed in master.
(which will be in 1-2 weeks).
There's nothing wrong with the fix, Jenkinsbot failed it because of a change to the way tests are run. There was a fix put into master (Gerrit change 20926) but that would also need to be backported to 1.20wmf10 before any other tests on 1.20wmf10 will succeed.