UW is not compatible with the classic skin
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	TheDJ
	Aug 24 2012, 2:26 PM

Description

UW depends on the following line in it's script:

// scroll to the top of the page (the current step might have been very long, vertically)

		var headScroll = $( '#firstHeading' ).offset();
		$j( 'html, body' ).animate( { scrollTop: headScroll.top, scrollLeft: headScroll.left }, 'slow' );

However #firstHeading is not present in the classic skin. Instead it has h1.pagetitle

Version: unspecified
Severity: normal

Details

Reference: bz39619

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:07 AM

• bzimport added a project: UploadWizard.

• bzimport set Reference to bz39619.

• bzimport added a subscriber: Unknown Object (MLST).

TheDJ created this task.Aug 24 2012, 2:26 PM

My apologies, this was a case of assuming that the extension operated on only (n - 1) dimensions. Is there a more-universal way of finding the top of the page that we could use?

I don't think so. but $( '#firstHeading, h1' ) is probably good enough in this case.

https://gerrit.wikimedia.org/r/21341

There ya go.

And thanks to sumana, I now have merge rights and can give you this one-line fix for relatively cheap.

Marking as resolved, we'll try to deploy this really soon. Thanks for the report!

• Gilles added a project: Multimedia.Dec 4 2014, 9:33 AM

• Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:10 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM

UW is not compatible with the classic skinClosed, ResolvedPublicActions

Description

Details

Event Timeline

UW is not compatible with the classic skin
Closed, ResolvedPublic
Actions