Page MenuHomePhabricator

UploadWizard needs to quit using funky array magic for upload lists
Open, LowPublic

Description

I just fixed bug 39608, which was nasty. It looks like this:

https://gerrit.wikimedia.org/r/21820

The reason I had to jump through hoops, as I explained, is partly because we play with the structure of our mw.UploadWizard.uploads array in funny ways.

I'd like to either

  1. Change it to be an object, not an array, and stop having to worry about it.
  1. Use an array, but don't mess with the order beyond making sure the uploads all appear in the proper sequence (i.e., don't always put them in the same place)
  1. Maybe even use an object *with the filenames as indices* and make it easier to find the proper files by the filename (maybe not, this seems like a stretch).

This should happen some other time, because really, it's low-ish priority. But it's a pretty nasty thing.


Version: master
Severity: minor

Details

Reference
bz39746