Page MenuHomePhabricator

Typing process using Narayam significantly slower when using jQuery 1.8.1
Closed, ResolvedPublic

Description

Hi, there is a problem with typing on OR WP. Typing using Narayam has become really slow for some reason. When you type something you do not see the transliteration instantly. Instead, it shows up after some time. Can someone please fix it?


Version: unspecified
Severity: critical

Details

Reference
bz39969

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:01 AM
bzimport set Reference to bz39969.
bzimport added a subscriber: Unknown Object (MLST).

Can you verify the same in other wikis (commons, translatewiki, etc) ? If its specific to OR WP, you might consider checking your common.js and user scripts you are using.

This doesn't looks like project specific or user specific problem. I am suffering same problem in meta and ml.wp (where Malayalam as input language). Various other users are also complaining about same problem.

This seems to regression due to 1.20wmf11. (Most probably jQuery update)

Copying community members. Please inform your respective village pumps about this bug.

Seems to be due to jQuery 1.8.1 update (bug 39908). Works fine with jQuery 1.8.0

Seems to be fine after reverting to jQuery 1.7.2

Reopened after rewording. If MediaWiki were to use jQuery 1.8.1 again, this would simply pop up again. Wikimedia having reverted to jQuery 1.7.2 doesn't fix the root cause.

Also, unrelated to this 'visible' problem, Krinkle noted

"btw, I see one big slow down in Narayam though that is bad no matter which version. Use of .live() with half a dozen events + using a proprietary selector ('input:text'). That means every single keydown event goes up every single element in the tree, all the way up to <html>, and *then* it is handled. First is goes through half a dozen selectors that can't be optimized with native document.querySelector but have to use Sizzle, and then it calls the ev handler'

So irrespective of the workable performance on 1.7.2, that should probably be improved a bit.

Fixed in I86cef90be993cef2470fe9a4892bbe55fcce191e.

Whatever is still slow after that change is to be blamed on how Narayam is designed. That needs refactoring later on. There is several major things that are inherently slow.