Page MenuHomePhabricator

VisualEditor: Pressing enter in a textarea should not submit the form (saveDialog-editSummary)
Closed, ResolvedPublic

Description

Submitting the form on Enter in the current UI goes against all expectations.

It is hardcoded in the javascript to override the default behavior (browsers are actually quite sane in this case and know not to auto-submit from a textarea because that's bad).

Either make it not a text area or make it not submit on Enter.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52133

Details

Reference
bz40034

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:06 AM
bzimport set Reference to bz40034.

Actually, this is exactly the current behaviour of the edit summary box; see bug 38042 and bug 38735 (the last one submitted by you :-)).

(In reply to comment #1)

Actually, this is exactly the current behaviour of the edit summary box; see
bug 38042 and bug 38735 (the last one submitted by you :-)).

Interesting. Was it a textarea back then?

Do we really need a textarea?

Newlines are not shown in page history.

(In reply to comment #4)

Do we really need a textarea?

Newlines are not shown in page history.

Maybe, maybe not. Either way, that's a separate request.

Besides, when it is a text input Enter will submit the form automatically (browser behavior) which is good. So this change had to be made either way. If you want, file a separate ticket to turn it into a single-line text input.

Note that textarea provides another thing besides multi-line: wrapping.

It is much nicer to type a long line in a textarea then a flat input because there is no need to use the horrible scrubbing behavior that browsers have (select-dragging or keyboard arrows only). I've encountered numerous times during usability studies that a user thought the begin of the input was lost when it was no longer visible (there is no visual indication that it is still there, e.g. scroll or whatever). Or that the end was lost (when they focus another element, other elements scroll back to the begin).

(In reply to comment #5)

Maybe, maybe not. Either way, that's a separate request.
[...]
If you want, file a separate ticket to turn it into a single-line text input.

bug 52133