Page MenuHomePhabricator

File related MWTimestamp::setTimestamp : Invalid timestamp exceptions
Closed, ResolvedPublic

Description

Brion fixed some of this in https://gerrit.wikimedia.org/r/#/c/22685/

But it seems to be still rather commonly appearing on Commons!

https://commons.wikimedia.org/wiki/File:2012-04_Re%C5%84ska_Wie%C5%9B_26.jpg

2012-09-06 01:02:25 srv279 commonswiki: [53d9f8ff] /wiki/File:2012-04_Re%C5%84ska_Wie%C5%9B_26.jpg Exception from line 130 of /usr/local/apache/common-local/php-1.20wmf11/includes/Timestamp.php: MWTimestamp::setTimestamp : Invalid timestamp - 1971:01:01 11:30:5500
#0 /usr/local/apache/common-local/php-1.20wmf11/includes/Timestamp.php(75): MWTimestamp->setTimestamp('1971:01:01 11:3...')
#1 /usr/local/apache/common-local/php-1.20wmf11/includes/GlobalFunctions.php(2412): MWTimestamp->__construct('1971:01:01 11:3...')
#2 /usr/local/apache/common-local/php-1.20wmf11/includes/media/FormatMetadata.php(107): wfTimestamp(1, '1971:01:01 11:3...')
#3 /usr/local/apache/common-local/php-1.20wmf11/includes/media/MediaHandler.php(364): FormatMetadata::getFormattedData(Array)
#4 /usr/local/apache/common-local/php-1.20wmf11/includes/media/ExifBitmap.php(138): MediaHandler->formatMetadataHelper(Array)
#5 /usr/local/apache/common-local/php-1.20wmf11/includes/filerepo/file/File.php(1403): ExifBitmapHandler->formatMetadata(Object(LocalFile), 'a:48:{s:4:"Make...')
#6 /usr/local/apache/common-local/php-1.20wmf11/includes/ImagePage.php(138): File->formatMetadata()
#7 /usr/local/apache/common-local/php-1.20wmf11/includes/actions/ViewAction.php(37): ImagePage->view()
#8 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(427): ViewAction->show()
#9 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(304): MediaWiki->performAction(Object(ImagePage))
#10 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(536): MediaWiki->performRequest()
#11 /usr/local/apache/common-local/php-1.20wmf11/includes/Wiki.php(446): MediaWiki->main()
#12 /usr/local/apache/common-local/php-1.20wmf11/index.php(59): MediaWiki->run()
#13 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#14 {main}


Version: 1.20.x
Severity: normal

Details

Reference
bz40037

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:07 AM
bzimport set Reference to bz40037.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 40043 has been marked as a duplicate of this bug. ***

It still apears. See bug 40043.

  • Bug 40242 has been marked as a duplicate of this bug. ***

The problem is, that wfTimestamp changed from false to exception on bogus input, that is a bad idea.

See gerrit 23783, which catch the exception and return false in that case to get the old behaviour back.

gerrit 23783 is successfully merged. Maybe backport to live site?

It should get deployed to Commons tomorrow (Wednesday).

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM