Page MenuHomePhabricator

OpenID extension lacks autodiscovery when used as a provider
Closed, ResolvedPublic

Description

Take for instance I have a wiki as a provider (wikiA) and another wiki as a consumer (wikiB). wikiA only acts as a provider, and wikiB acts as a consumer, but is forced to use wikiA as a provider ($wgOpenIDConsumerForce = http://wikiA.example.org).

Currently this is impossible since the OpenID extension, when used as a provider, only does discovery on a user-per-user basis by providing user page URLs.

The extension should provide a discovery URL that does the following:

  1. If a user is currently logged in, it should return the user's openid information
  2. If a user is not logged in, it should redirect to the login page. When the user logs in, it should redirect back, which should return the openid information.

Version: master
Severity: normal

Details

Reference
bz40068

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:09 AM
bzimport set Reference to bz40068.

sumanah wrote:

Tyler, would you be able to take a look at this as well? Ryan says it's a blocker for using a paste app he'd like to install (as is bug 40067).

"OpenID as a provider

As time goes on we want to tie more web service authentication to Labs' LDAP. It would be ideal to make labsconsole an OpenID provider so that services in Labs can use the same authentication source. OpenID as a provider on labsconsole is blocked by bugs 40068 and 40067."

http://www.mediawiki.org/wiki/Wikimedia_Labs/Account_creation_improvement_project

  • This bug has been marked as a duplicate of bug 25771 ***

This is not a duplicae of bug 25771.

Bug 25771 is regarding OpenID as a consumer in MediaWiki and this bug is regarding OpenID as a provider in MediaWiki.

I'm not sure why this doesn't work, but this patch is supposed to fix this: https://gerrit.wikimedia.org/r/45554

Maybe somebody can find what I'm doing wrong.

Can you add/test it in the openid-wiki instance on labs? I've added you to the project. The code is at /srv/mediawiki and can be accessed by: http://openid-wiki.instance-proxy.wmflabs.org/wiki

Ryan, Tyler:

Stop. I already have edited this version ! it's a "self-service" according to your chat yesterday - and not good to have two developers acting on the same instance.

(In reply to comment #7)

Ryan, Tyler:

Stop. I already have edited this version ! it's a "self-service" according to
your chat yesterday - and not good to have two developers acting on the same
instance.

Then what about assigning that bug to yourself so others don't feel that nobody is looking into it? ;)

overlooked, that the bug wasn't assigned. ty

ETA of tests: Saturday evening 20130126 UTC

Status report: I managed to solve all the open issues of #40068.

A new patchset will be committed in a couple of hours, or earlier.

This isn't merged in yet, so I'm reopening the bug until that's the case.