Page MenuHomePhabricator

Version number shouldn't always use localized parentheses
Closed, ResolvedPublic

Description

In some commit version numbers are changed to use localized parentheses however sometimes they're used in English context, for example in a maintenance script it says:

This is MediaWiki version 1.20alpha (b8256e7).

()[ = localized version in zh ] shouldn't be used here.


Version: 1.21.x
Severity: minor

Details

Reference
bz40254

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:53 AM
bzimport set Reference to bz40254.

Please provide explicit steps to reproduce where this occurs. Otherwise it's really hard to go about resolving this issue.

Sounds like some of our maintenance scripts should hardcode a script lang of en.

(In reply to comment #1)

Please provide explicit steps to reproduce where this occurs. Otherwise it's
really hard to go about resolving this issue.

I can't find that specific script now... is it already fixed?

[resetting status, assuming that Liangent changed it accidentially]

Liangent:

Only match when grep'ing is in ./tests/parserTests.php :

  1. Print out software version to assist with locating regressions $version = SpecialVersion::getVersion(); echo "This is MediaWiki version {$version}.\n\n";

See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fspecials%2FSpecialVersion.php#L228 from there.

(In reply to Andre Klapper from comment #6)

Liangent:

Only match when grep'ing is in ./tests/parserTests.php :

  1. Print out software version to assist with locating regressions $version = SpecialVersion::getVersion(); echo "This is MediaWiki version {$version}.\n\n";

See
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/
includes%2Fspecials%2FSpecialVersion.php#L228 from there.

Yeah it is parserTests.php. Spotted again just now when using it.

Change 135162 had a related patch set uploaded by FunPika:
Don't localize parentheses in version number in parserTests.php

https://gerrit.wikimedia.org/r/135162

The patch was merged, so was this issue fixed?