Page MenuHomePhabricator

invalid xml node "4::tags" in API response
Closed, ResolvedPublic

Description

Since Sep. 7, we noticed that the response to the following API calling contains invalid XML piece "<4::tags>..</4:tags>", which breaks XML parser. Could anyone take a look and work on a fix? Thanks

http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=1&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-09-10T19:40:09Z

Response looks like:

<?xml version="1.0"?><api><query><recentchanges><rc type="log" ns="0" title="Artists and Instigators" rcid="527149348" pageid="36976290" revid="0" old_revid="0" user="Breawycker public" oldlen="0" newlen="0" timestamp="2012-09-10T19:40:09Z" comment="" logid="44607537" logtype="pagetriage-deletion" logaction="delete"><4::tags><param>db-g11</param></4::tags></rc></recentchanges></query><query-continue><recentchanges rcstart="2012-09-10T19:40:09Z" /></query-continue></api>


Version: master
Severity: critical

Details

Reference
bz40299

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:56 AM
bzimport added a project: PageTriage.
bzimport set Reference to bz40299.
  • This bug has been marked as a duplicate of bug 40195 ***

Not sure if this is really a duplication of bug 40195. In this case, we are seeing invalid XML node, while in bug 40195, the invalid pieces are in XML attributes.

Hmm, yeah, bit quick there.

I'm guessing it's possibly PageTriage related...

logtype="pagetriage-deletion"

I remember Benny explaining to me at some point what this was for, but I can't remember now.

(In reply to comment #7)

the link below still returns invalid pieces, do you need to fix any historical
data as well?

http://en.wikipedia.org/w/api.php?action=query&format=xml&list=recentchanges&rclimit=1&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C100&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser&rcstart=2012-09-10T19:40:09Z

Needs merging to production, and then the maintenance script running

For anyone else that cares, https://gerrit.wikimedia.org/r/#/c/24148/

https://gerrit.wikimedia.org/r/#/c/24259/
https://gerrit.wikimedia.org/r/#/c/24260/

reedy@fenari:/home/wikipedia/common$ mwscript extensions/PageTriage/tools/cleanupPageTriageLog.php testwiki
processed pagetriage-curation tag: 3
processed pagetriage-curation delete: 1
processed pagetriage-deletion delete: 1
reedy@fenari:/home/wikipedia/common$ mwscript extensions/PageTriage/tools/cleanupPageTriageLog.php enwiki
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 100
processed pagetriage-curation tag: 3
processed pagetriage-curation delete: 100
processed pagetriage-curation delete: 100
processed pagetriage-curation delete: 36
processed pagetriage-deletion delete: 100
processed pagetriage-deletion delete: 100
processed pagetriage-deletion delete: 36

Should only be squid level caching now...