Page MenuHomePhabricator

PID file for pollForChanges does not work with a wiki family setup.
Closed, ResolvedPublic

Description

Using FILE as a basis is not the correct way to get separate pid files for separate wikis, because multiple wikis may use the same install base. This is especially true for the installations run by Wikimedia. Either get the PID file from the command line, or use something like wfWikiID().

Some more minor issues:

I would reserve .lck for actual lock files. This is not really a lock file. .pid is often used on unix for this, look into your /var/run directory for examples.

Under *nix, it would be nicer to use a file in /var/run (you will see a whole bunch of .pid files there already). The file in /var/run would need to be created and chowned to the correct user for that to work though.

Perhaps just try to use /var/run/xyz first (check whether the dir exist and the file is writable / can be created), otherwise use the OS' temp dir.


Version: unspecified
Severity: normal

Details

Reference
bz40327

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:58 AM
bzimport set Reference to bz40327.
bzimport added a subscriber: Unknown Object (MLST).

For reference, the PID stuff was introduced by I82973368.