Page MenuHomePhabricator

Bugzilla auto-linking mangling Gerrit URL
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=MobileFormatter.php;h=e54b7c312985e3ebd569cac1fb4f34c597f4e8b8;hb=HEAD

Bugzilla's auto-linker is mangling this Gerrit URL. It should look like the concatenation of:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ \
MobileFrontend.git;a=blob;f=MobileFormatter.php; \
h=e54b7c312985e3ebd \
569cac1fb4f34c597f4e8b8;hb=HEAD


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=35144

Details

Reference
bz40344

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:59 AM
bzimport set Reference to bz40344.

I've noticed this as well and it is most annoying! I wonder if the latest Bugzilla upgrade fixes this?

(In reply to comment #1)

I've noticed this as well and it is most annoying! I wonder if the latest
Bugzilla upgrade fixes this?

I doubt it has anything to do with Bugzilla directly. Wikimedia has a Bugzilla extension that performs a few auto-linking regexen on Bugzilla comments. I imagine this particular regex just needs a tweak.

I noticed on bug 41745 comment 5 that the email I received had a correct link, so I suppose the damage is not permanent.
Also:
2012-11-03 20.56 < jeremyb> why are spaces escaped there?
2012-11-03 20.56 < jeremyb> > match => qr{\brt\ ?\#?(\d+)}i

It only affects the rendering - the XML view at https://bugzilla.wikimedia.org/show_bug.cgi?ctype=xml&id=41745 also shows it correctly.

The issue seems to be that a word boundary

\b

also covers

=

while this is not intended by its author.

Patch at https://gerrit.wikimedia.org/r/#/c/33557/ , review and testing welcome.

Gerrit annoys the hell out of me and wastes my time, so I unassign this though the patch works and is tested. See Gerrit.

and another change to move the Extension.pm from 4.0 to 4.2 directory

https://gerrit.wikimedia.org/r/#/c/39065/