Add missing dependencies for modules "mediawiki.user" and "mediawiki.action.view.dblClickEdit"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	He7d3r
	Sep 20 2012, 9:30 PM

Description

I think the module "mediawiki.user"
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l624
should have "user.tokens" as dependecy because of this line:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki/mediawiki.user.js#l249
249 mw.user = new User( mw.user.options, mw.user.tokens );

Also, the module
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
uses mw.util.$content, so it should have 'mediawiki.page.startup' as dependency:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l661

Version: unspecified
Severity: normal

Details

Reference: bz40415

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:04 AM

• bzimport added projects: MW-1.20.0-release, MediaWiki-JavaScript, good first task, JavaScript.

• bzimport set Reference to bz40415.

He7d3r created this task.Sep 20 2012, 9:30 PM

Nice catch, to both.

Just for your information though. The dependency on mediawiki.user is not subject to the usual race condition because user.tokens is embedded into the HTML output.

if you like, put up a patchset on gerrit. Otherwise, I'll assign for next week.

(btw, removing from component ResourceLoader, onto MediaWiki core > JavaScript. This is not related to the ResourceLoader framework, but the javascript modules in mediawiki itself).

Gerrit Change I5ef5e4ab

Landed in master.

Add missing dependencies for modules "mediawiki.user" and "mediawiki.action.view.dblClickEdit"Closed, ResolvedPublicActions

Description

Details

Event Timeline

Add missing dependencies for modules "mediawiki.user" and "mediawiki.action.view.dblClickEdit"
Closed, ResolvedPublic
Actions