Page MenuHomePhabricator
Create Task
Maniphest T42478

AbuseFilter needs regression tests
Closed, ResolvedPublic
Actions

Description

There are no unit tests in AbuseFilter at the moment. Even phpTest.php has to be called manually. There should be a test suite that simulates common uses.

Basic tests to implement:

See Also:

Examples of filters broken by updates:

Details

Reference
bz40478
SubjectRepoBranchLines +/-
Add PHPUnit tests for various generic functionsmediawiki/extensions/AbuseFiltermaster+1 K -0
Add phpunit tests for creating and editing filtersmediawiki/extensions/AbuseFiltermaster+686 -0
Add tests for filter consequencesmediawiki/extensions/AbuseFiltermaster+774 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:08 AM
• bzimport added a project: AbuseFilter.
• bzimport set Reference to bz40478.
• bzimport added a subscriber: Unknown Object (MLST).
scfc created this task.Sep 24 2012, 2:53 PM
He7d3r added a comment.EditedAug 16 2013, 1:04 PM

Would this kind of test help us prevent unwanted side effects of changes such as T52107?

He7d3r added a comment.EditedAug 17 2013, 12:13 AM

(In reply to comment #1)

Would this kind of test help us prevent unwanted side effects of changes such
as T52107?

and T54053...

• werdna unsubscribed.Dec 10 2014, 6:17 PM
He7d3r updated the task description. (Show Details)May 23 2015, 6:50 PM
He7d3r added a project: MediaWiki-Core-Tests.
He7d3r set Security to None.
He7d3r mentioned this in T100069: added_lines include whitespace at the beginning.
He7d3r updated the task description. (Show Details)
He7d3r updated the task description. (Show Details)May 25 2015, 2:49 AM
He7d3r mentioned this in T100249: AbuseFilter adds spaces before "added_lines", causing many false positives.
He7d3r mentioned this in T74329: "added_lines" is not in "new_wikitext" anymore and causes false positives.
He7d3r mentioned this in T100892: Notify SOMEONE that an abusefilter had a sudden increase in the number of logs.May 30 2015, 1:36 PM
matej_suchanek mentioned this in T106136: Wikidata edits are not tagged by AbuseFilter on item creations.Jul 17 2015, 12:46 PM
Krinkle removed a project: MediaWiki-Core-Tests.Jan 12 2017, 11:04 PM
Krinkle updated the task description. (Show Details)
Krinkle removed a subscriber: • wikibugs-l-list.
Huji subscribed.Jan 13 2017, 1:46 AM
He7d3r mentioned this in T178010: missing character equivalencies: ÈÉÊẼÌÍÏÓÒÔÕ∅Q̃ÚŰÜŨ.Nov 21 2017, 6:29 PM
Daimona awarded a token.Mar 23 2018, 8:35 PM
Daimona subscribed.
matej_suchanek raised the priority of this task from Low to High.Apr 6 2018, 9:36 AM
matej_suchanek added a project: Test-Coverage.
Daimona added a comment.Apr 6 2018, 9:42 AM

Yeah, definitely time to think about this. I'm not familiar with phpunit but I'd love to give some help.

Huji added a subscriber: matej_suchanek.Apr 6 2018, 9:55 PM

I think this needs a (much needed) overhaul of the way AbuseFilter is coded. Quoting @matej_suchanek from an email, the plan could be to split it to a new class (say, AbuseFilterRunner) and cover it with tests.

Huji closed subtask T193596: Abstract out parts of AbuseFilterViewEdit that deal with saving a filter as Resolved.Jul 2 2018, 10:23 PM
gerritbot subscribed.Jul 2 2018, 11:21 PM

Change 443520 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add phpunit tests for creating filters

https://gerrit.wikimedia.org/r/443520

gerritbot added a project: Patch-For-Review.Jul 2 2018, 11:21 PM
gerritbot added a comment.Jul 6 2018, 10:10 AM

Change 444191 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add PHPUnit tests for various generic functions

https://gerrit.wikimedia.org/r/444191

Daimona added a comment.Jul 7 2018, 1:09 PM

This is what I'm progressively try to add as tests:

  1. Tests for all AFPUserVisibleException exceptions
  2. Tests for filter validation
  3. Tests for generic functions in AbuseFilter class
  4. Complete tests where filters are created, actions are executed and consequences must be taken.

Apart from the latter, everything is under review right now.

gerritbot added a comment.Jul 8 2018, 4:08 PM

Change 444442 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Add tests for filter consequences

https://gerrit.wikimedia.org/r/444442

Daimona claimed this task.Jul 8 2018, 4:09 PM

I think the above patches will provide a really good test background to start with, and should accomplish the goal of this task. Then, they may be expanded progressively.

gerritbot added a comment.Jul 18 2018, 1:14 AM

Change 444442 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add tests for filter consequences

https://gerrit.wikimedia.org/r/444442

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 5:01 AM
Daimona updated the task description. (Show Details)Jul 18 2018, 7:15 AM
gerritbot added a comment.Jul 24 2018, 4:04 PM

Change 443520 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add phpunit tests for creating and editing filters

https://gerrit.wikimedia.org/r/443520

Huji updated the task description. (Show Details)Jul 24 2018, 4:04 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)); removed MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 24 2018, 5:00 PM
Daimona updated the task description. (Show Details)Aug 2 2018, 10:04 AM
Huji added a parent task: T201193: Code coverage is low in AbuseFilter, Aim to increase to 50%.Aug 3 2018, 6:19 PM
Huji mentioned this in T201193: Code coverage is low in AbuseFilter, Aim to increase to 50%.
gerritbot added a comment.Aug 9 2018, 8:44 PM

Change 444191 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add PHPUnit tests for various generic functions

https://gerrit.wikimedia.org/r/444191

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)); removed MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Aug 9 2018, 9:00 PM
Daimona closed this task as Resolved.Aug 9 2018, 9:08 PM
Daimona removed a project: Patch-For-Review.
Daimona updated the task description. (Show Details)

Now we have the base. The parent task is here to track further improvements.

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM
matej_suchanek unsubscribed.Aug 17 2018, 9:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL