Page MenuHomePhabricator

CentralNotice unit tests broken
Closed, ResolvedPublic

Description

Fatal error: Call to a member function addCampaign() on a non-object in /www/dev.translatewiki.net/w/extensions/CentralNotice/tests/CentralNoticeTest.php on line 38


Version: master
Severity: major

Details

Reference
bz40484

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:09 AM
bzimport set Reference to bz40484.
bzimport added a subscriber: Unknown Object (MLST).

Fairly obvious if you look at the code, self::$centralNoticeDB doesn't get anything assigned to it

And while someone ins in there...

There are to @todo FIXMEs needing passing of a user parameter

mwalker wrote:

Patch merged - the tests still fail - but at least they don't crash!

Thanks Nischay for making that change. :)

Next up: updating the tests so that they test the new architecture! Anyone? :p I'll get around to it eventually but certainly no one should wait for me.