Page MenuHomePhabricator

ResourceLoader should not ignore media-type for urls in debug mode
Closed, ResolvedPublic

Description

Steps to reproduce:

Expected result:

  • Two <link> tags are added. main.css and print.css. print.css should not be active (in order words, media=print)

Actual result:

  • Both are added without a media type.

This is actually quite easy to fix. Though we no longer support media-type for minified css strings (which is fine because we wrap them in @media on the server side), we have to support it still for urls.


Version: 1.18.x
Severity: normal

Details

Reference
bz40500

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:10 AM
bzimport set Reference to bz40500.

Will be fixed in my rl-refactor branch. Pushing soon with reference to this bug.

Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.

(In reply to comment #4)

See Gerrit I3c76e9a8

No, the change id was already posted it is:

(In reply to comment #2)

Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.

(In reply to comment #2)

Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.

Landed in master, and merged to REL1_20.