Page MenuHomePhabricator

Get rid of Wikipedia-Specific code
Closed, ResolvedPublic

Description

Find and remove any wikipedia specific logic hardcoded in wikibase.

Tim mentioned several here: https://bugzilla.wikimedia.org/show_bug.cgi?id=38822#c7

Full quote:

In ItemView.php:

/**

  • Returns a list of all the sites that can be used as a target for a site

link.

  • @static
  • @return array */

public static function getSiteDetails() {
...

if ( $site->getType() === Site::TYPE_MEDIAWIKI && $site->getGroup() ===

'wikipedia' ) {

The autocomplete feature that this function services also references Wikipedia
in a message (wikibase-error-autocomplete-connection).

There doesn't seem to be any way to populate the sites table with data other
than the data that comes from meta.wikimedia.org, I had to patch
Utils::insertDefaultSites() to set up my test instance.

populateInterwiki.php also unconditionally references Wikipedia.


Version: unspecified
Severity: normal

Details

Reference
bz40594

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:47 AM
bzimport set Reference to bz40594.
bzimport added a subscriber: Unknown Object (MLST).

Can we identify what's still missing here to start splitting this into manageable tasks?

As far as I know, we fixed all of these issues when adding support for wikivoyage and commons.