Page MenuHomePhabricator

'version-poweredby-others' message should not link to MediaWiki CREDITS file
Closed, ResolvedPublic

Description

I disagree with this change, from July:

https://gerrit.wikimedia.org/r/#/c/13558/

The message 'version-poweredby-others', which shows up when you add '...' to a list of authors in $wgExtensionCredits, was changed from just reading "others" (in English), to being a link to the MediaWiki CREDITS file. This makes sense for core MediaWiki, of course, but it doesn't make any sense for extensions - and many extensions use that '...' notation. I believe the change should be reverted, and the linking should instead be done in whatever code specifically handles the display of core MediaWiki credits in Special:Version.


Version: 1.20.x
Severity: trivial

Details

Reference
bz40666

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:53 AM
bzimport set Reference to bz40666.
bzimport added a subscriber: Unknown Object (MLST).

[ Adding 'code-update-regression' keyword. ]

[ Adding Liagent as cc, as he's the change author. ]

Huh it got merged?

I haven't touch it again for months,

Yes, according Gerrit history, it was merged by Hashar July 2nd.

Nikerabbit and Siebrand then recommended the same day to revert the change.

The discussion stopped there.

It looks like this was fixed just two days later:

https://gerrit.wikimedia.org/r/#/c/26468/

I should have checked earlier...