Page MenuHomePhabricator

searchsuggest-containing line ("containing...") doesn't include the entered text
Closed, ResolvedPublic

Description

When searching on 1.21wmf1 or later wikis, the bit in the search suggestions where it says "containing..." doesn't provide the text that's entered into the search box.

Repro:

  1. Enter search text "foo" on 1.21wmf1 wiki
  2. Read the suggestions area

Expected: option which has "containing... foobar"
Actual: option which only has "containing..."

Possible cause: deployment of SimpleSearch (see bug 29374)


Version: unspecified
Severity: normal

Details

Reference
bz40780

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:01 AM
bzimport set Reference to bz40780.

SimpleSearch has been deployed on wmf for over a year, we only changed mediawiki defaults recently.

Probably caused by a small error when SimpleSearch from ext.Vector was moved into core to replace legacy.mwsuggest.

This issue appears timing-dependent; with repeated reloads I can sometimes but not always reproduce in Chrome and FF on 1.12wmf1 wikis.

It would be good to get this fixed before further 1.21wmf1 deployments.

Caused by a number of small issues unrelated to mediawiki.searchSuggest, it just happend to trigger them in a combination exposing them this way.

Fix in I4649ec0c89d38c4d79d1dceec28227902cd48d32.