Page MenuHomePhabricator
Create Task
Maniphest T42899

Resources for anonymous users are not cached
Closed, ResolvedPublic
Actions

Description

Author: jakub

Description:
Anonymous users have mTouched set to "0" meaning that they have never been modified. But wfTimestamp() treats this value as "now" causing the exact opposite. The consequence is that static resources loaded under anonymous user are never cached.

This looks like a clear bug, even the source code comment suggest that this value should cause caching of any page. The attached patch fixes this.

This is network communication before: http://www.vrana.cz/test/mediawiki/before.png and after: http://www.vrana.cz/test/mediawiki/after.png. The difference between 1.59 s and 2.63 and the 304 status are important.

Version: 1.20.x
Severity: minor

Details

Reference
bz40899

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:09 AM
• bzimport added projects: MW-1.21.0-release, MediaWiki-ResourceLoader.
• bzimport set Reference to bz40899.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Oct 9 2012, 10:19 PM
• bzimport added a comment.Oct 9 2012, 10:23 PM

jakub wrote:

Fix

Attached:

bug-40899.patch869 BDownload

• bzimport added a comment.Oct 11 2012, 1:40 AM

sumanah wrote:

Jakub, thanks for the fix! Just so you know, in the future you can submit your changes directly into our Git repository using developer access: https://www.mediawiki.org/wiki/Developer_access

Catrope added a comment.Oct 11 2012, 1:44 AM

Thanks for the patch! Submitted into Gerrit as https://gerrit.wikimedia.org/r/#/c/27498/ and merged.

Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 6:13 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL