Page MenuHomePhabricator

ExtensionDistributor does not work: "Invalid response from Extension Distributor remote client"
Closed, ResolvedPublic

Description

At moment the ExtensionDistributor on MW.org does not work. It outputs the error message: "Invalid response from Extension Distributor remote client.".

For example see this URL: http://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdist_extension=APC&extdist_version=branches%2FREL1_19&extdist_submit=Continue


Version: wmf-deployment
Severity: major
URL: http://www.mediawiki.org/wiki/Special:ExtensionDistributor/Cite

Details

Reference
bz41081

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:52 AM
bzimport set Reference to bz41081.
  • Bug 41162 has been marked as a duplicate of this bug. ***
  • Bug 41215 has been marked as a duplicate of this bug. ***

It's broken again :( reopening as per complains on mw.org support desk

  • Bug 41824 has been marked as a duplicate of this bug. ***

Chad: Could you take a look at this?

Started digging into this last night, but couldn't find the root of the problem.

We are at least connecting to the socket fine in updateAndGetRevisionRemote() (otherwise we'd hit 'extdist-no-remote'), but for some reason we're not getting a response from it. $response && $encResponse are both empty strings, which is odd (and what's causing 'extdist-remote-invalid-response').

I didn't get much further than that last night to figure out why we were getting an empty response--I don't know if it was svn-invoker on the remote client end, or what.

(In reply to comment #9)

I didn't get much further than that last night to figure out why we were
getting an empty response--I don't know if it was svn-invoker on the remote
client end, or what.

Well, fenari:/var/log/svn-invoker.log shows failures, which probably means xinetd is getting a non-zero exit status from svn-invoker.php. Maybe it is a PHP fatal error or something.

bugzilla.mediawiki wrote:

in the meantime any alternative way of getting data for the extensions for the 1.19 release ? git only shows me master branch, no other remote branch, svn seems not be used any longer as you guys moved to git

eg CharInsert - http://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdist_extension=CharInsert&extdist_version=branches%2FREL1_19&extdist_submit=Continue

Thanks

(In reply to comment #11)

in the meantime any alternative way of getting data for the extensions for the
1.19 release ? git only shows me master branch, no other remote branch, svn
seems not be used any longer as you guys moved to git

ExtensionDistributor uses Subversion. So if you want to get the same version that it uses, you should just use Subversion:

svn export http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_19/extensions/<EXTENSION NAME>

In Git, there are no extension branches for core releases.

Fixed. A git process was stuck in a deadlock (parent and child process both reading from each other). I killed it.

Note that the extension is still broken in other ways for the "trunk" version, but 1.19 downloads appear to work.

"Invalid response from Extension Distributor remote client."

http://www.mediawiki.org/wiki/Special:ExtensionDistributor/Cite

Reopening again.

Shameless plug:

It seems like there's a larger problem here - managing extensions. This topic has come up time & again at meetings, IRC, the mailing list(s), etc. I've started an RFC page at http://www.mediawiki.org/wiki/Requests_for_comment/Extension_manager if anyone would like to comment/contribute/lament.

There are now several reports in Project:Support_desk about this, and it's going to be a week since the report on this bug without a solution, despite being marked as High/Critical.

If it's a simple thing as described in comment 13 by Tim Starling it should be fast to fix.

Tim / Chad: Could one of you look at this?
Or any idea who could look at this?

Tim's on vacation. I looked at it, and tried to do what Tim had done before (kill the hung Git processes), but it didn't work. I really don't know what else to do.

I started rewriting ExtensionDistributor entirely instead.

That's great. I'd prefer it if the new version was completely decoupled from upload.wm.org, as it messes with the way we're setting up upload right now (NFS dependency) and it's kind of out of scope for upload (it's not user-uploaded content).

in wmf-config there seems to be an issue with settings...

./extdist/svn-invoker.conf:$wgExtDistWorkingCopy = '/mnt/upload7/private/ExtensionDistributor/mw-snapshot';

but

./CommonSettings.php: $wgExtDistWorkingCopy = '/mnt/upload6/private/ExtensionDistributor/mw-snapshot';

(In reply to comment #21)

in wmf-config there seems to be an issue with settings...

./extdist/svn-invoker.conf:$wgExtDistWorkingCopy =
'/mnt/upload7/private/ExtensionDistributor/mw-snapshot';

but

./CommonSettings.php: $wgExtDistWorkingCopy =
'/mnt/upload6/private/ExtensionDistributor/mw-snapshot';

This was it. Should both be upload6. Fixed this, and ExtDist is now working.

(In reply to comment #20)

That's great. I'd prefer it if the new version was completely decoupled from
upload.wm.org, as it messes with the way we're setting up upload right now
(NFS
dependency) and it's kind of out of scope for upload (it's not user-uploaded
content).

Yeah, we definitely want to rewrite this extension and get it off upload.wm.o. I started an RFC. https://www.mediawiki.org/wiki/Requests_for_comment/Replacing_extension_distributor

This issue is fixed. We'll use bug 37946 to track the new version of ExtensionDistributor.