Page MenuHomePhabricator
Create Task
Maniphest T43315

EditPage should fail gracefully when getting incompatible model/format values
Closed, ResolvedPublic
Actions

Description

Per bug 41309 [1], it was possible to specify action=edit&model=fjlsgk (or even something like css)

Then click preview and see fatal exception.

https://bugzilla.wikimedia.org/show_bug.cgi?id=41309

Per gerrit change 29616, we use only the default model and format now:

https://gerrit.wikimedia.org/r/#/c/29616/1/includes/EditPage.php

Just want to ask if there is any reason for allowing these parameters in EditPage? If so, there were some to-do items in the code and we should implement it in a better way.

Until then, I don't see benefit of having these parameters in EditPage.

Version: 1.21.x
Severity: normal

Details

Reference
bz41315

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:10 AM
• bzimport added projects: MW-1.22-release, MediaWiki-ContentHandler.
• bzimport set Reference to bz41315.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Oct 23 2012, 5:54 PM
daniel added a comment.Oct 24 2012, 2:45 PM

Yes, they are needed to edit any page that uses a non-default text-based content model. For example, if there was for some reason a CSS page in the Help namespace, removing these parameters would cause the CSS to be treated as wikitext upon save.

As long as only the default content type (derived from the namespace and other parts of the page title) is used, these parameters are not needed. But as soon as this is not the case, we *will* need them.

daniel added a comment.Oct 24 2012, 3:50 PM

See also my comments to I93be7c4e

daniel added a comment.Oct 29 2012, 6:02 PM

I think we do need parameters, and editing should fail for invalid content models, but perhaps not with a fatal error or internal error. We should check earlier and report more nicely.

Shall we re-purpose this ticket for that, or shall we open a new one?

aude added a comment.Oct 29 2012, 6:04 PM

either works for me. this was mainly a discussion item but if we can decide on a solution and implement it, then bug fixed

Aklapper added a comment.Mar 20 2013, 3:43 PM

Note: As this has the 1.21.0 target milestone set (by Krinkle), somebody would have to make a decision (see comment 3 by Daniel Kinzler and comment 4 by Aude). If this does not receive a decision / patch in the next weeks, the Target Milestone will likely get removed.

Umherirrender added a comment.Jan 31 2014, 7:14 PM

Already fixed with bug 57615?

Aklapper added a comment.Feb 26 2014, 3:42 PM

Aude / Daniel:

(In reply to Umherirrender from comment #6)

Already fixed with bug 57615?

duplicatebug added a comment.Mar 1 2014, 12:27 PM

Fixed with gerrit 97835

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL