Currently, putting "G-errit 2.5" (minus the minus) in a comment causes a link to a Gerrit change id 2. This is kinda dumb, since the odds of someone actually referring to https://gerrit.wikimedia.org/r/#/c/2 are almost zero.
Can we make the Gerrit regex in BZ a little less aggressive about linking to Gerrit? I'd like to at least be able to refer to the next version of the software without my comments being mauled.
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T24596 Migrate subversion to git | |||
| Resolved | None | T37144 Autolink to new Gerrit / Git changesets and SHA-1 commits | |||
| Resolved | Aklapper | T43321 Comments with the string "Gerrit 2.5" should not link to Gerrit. |
Anybody with RegEx skills can give it a shot here:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm?revision=115449&view=co
Assuming that Gerrit version 10 is not around the corner,
match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d+)}i,should be replaced by
match => qr{\bgerrit(\ change(set)?)?\ ?\#?(\d{2,})}i,I'll cook up a Gerrit patch once my other one got in.
merged:
https://gerrit.wikimedia.org/r/#/c/35840/
applied on "4.2" dir:
https://gerrit.wikimedia.org/r/#/c/39068/
..and deployed in production