Page MenuHomePhabricator

Deleted images still appear
Closed, ResolvedPublic

Description

On Wikimedia Commons, there appears to be a problem deleted images that remain visible, such as this one:

http://commons.wikimedia.org/wiki/File:Iogurte_de_morango.jpg

http://commons.wikimedia.org/wiki/Commons:Village_pump#Image_not_deleting.3F

The page appears deleted (e.g. in the logs, etc.) but not the file and file history.


Version: unspecified
Severity: critical

Details

Reference
bz41343

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:11 AM
bzimport set Reference to bz41343.
bzimport added a subscriber: Unknown Object (MLST).

MediaWiki/File Management -> Wikimedia/File management. More than likely related to swift and etc than the core file management.

sumanah wrote:

Aude, when did this start, and is there any pattern to the deletions affected?

I'm sure I saw that on other MediaWiki installations as well, with older MediaWiki versions.

Probably because the deletion of the page was done, and then some weird error occurred. Then the file wasn't moved to the "deleted" folder, and not deleted from the file table. That's strange, since I know that database is transactional but the filesystem changes we do aren't, if an error occurred the transaction should be rolled-back but it seems that a partial transaction got commited.

Does this happen frequently? I ask because of the current importance/priority (Higest/Critical). This example could be fixed restoring+deleting again, or uploading+deleting.

@sumanah: no idea but just passing along this from the village pump on commons.

It's one thing if it's an isolated case but not sure.

okay, restoring and deleting it again fixed this one.

http://commons.wikimedia.org/wiki/Commons:Village_pump#Image_not_deleting.3F

I'll mark it as resolved and hope it's an isolated case.

This has happened before. Often due to the server park instability. It's basically the same that happens with uploads, where we also sometimes see files or pages missing.

Bryan.TongMinh wrote:

Indeed, this is probably one of those cases that can be fixed by doing the update of the page and image table and the physical file moving in a single transaction.

Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald Transcript