Page MenuHomePhabricator

Show result of check if Username == Password on same page instead of page after
Closed, ResolvedPublic

Description

Author: tshrinivasan

Description:
When we install mediawiki, If I give the administrator username and password as a same string, it reports as an error in the last page of installation and asking me to go back to change this.

The validation and similarity check should be done on the same page and reported in that page itself before moving to next page.

Example:

http://localhost/mediawiki-alpha/core/mw-config/index.php?page=Name

Administrator account

Your name: shrini

password: shrini
passoword again: shrini

Get the error only in the following page.
http://localhost/mediawiki-alpha/core/mw-config/index.php?page=Install

error message:

Internal error when setting a password for the admin "Shrini":

Your password must be different from your username.

This should be checked using javascript and displayed in the same "page=Name"
page.

Please fix this.


Version: 1.19.1
Severity: enhancement

Details

Reference
bz41392

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:44 AM
bzimport set Reference to bz41392.

Change 105428 had a related patch set uploaded by 01tonythomas:
Result shown if username and password are same on same page of installer

https://gerrit.wikimedia.org/r/105428

Change 109888 had a related patch set uploaded by 01tonythomas:
Changed the password $valid check condition

https://gerrit.wikimedia.org/r/109888

Change 105428 abandoned by 01tonythomas:
Error shown if Administrator username and password match in the installer

Reason:
in favour of
https://gerrit.wikimedia.org/r/109888
which fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=41392

https://gerrit.wikimedia.org/r/105428

Change 109888 merged by jenkins-bot:
Changed the password $valid check condition

https://gerrit.wikimedia.org/r/109888