Page MenuHomePhabricator

If course page was moved, "deleted revisions" appear at the old title, attemping undeletion causes DB error
Closed, DeclinedPublic

Description

When I edit a course page and change the "Page title", I get returned to the old title, which now shows "deleted revisions". Previous edits to the course page still show up in recent changes under the old title, which is a now a red link.

I can attempt to undelete the "deleted revisions" at the old page title, but it remains empty. However a log entry for undeleting the page appears in recent changes, even though it is still a red link.

I'm not sure what the behavior ought to be, but perhaps it shouldn't be possible to move the page simply by changing the Page title in the edit interface. (Instead, moving should only be done with a standard "Move page" operation that limits the move to valid course page titles.) Alternatively, pages moved through changes in the "Page title" should leave log messages about the move (noting the old and new titles), and after the edit the user should be sent to the new title rather than the (now non-existent) old one.


Version: unspecified
Severity: normal

Details

Reference
bz41500

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:52 AM
bzimport set Reference to bz41500.
bzimport added a subscriber: Unknown Object (MLST).

This sounds like breakage caused by the title schema change. This should be fixed on master.

Edits are not expected to be removed from RC after deletion AFAIK. If this is something we want, it's an enhancement request (which should have a entry on bugzilla). And one that we probably get for free when changing he extension over to use ContenHandler.

Closing this as FIXED since I do not think the error still occurs on master

I'm not sure this was ever fixed (or if it was, I should have reopened it when it started again). There's a new wrinkle: attempting to undelete based on the faulty "deleted revisions" message results in a database error:

Function: ORMRow::insert
Error: 1062 Duplicate entry '313' for key 'PRIMARY' (10.64.32.22)

We'll disable changing the title of course pages soon, but that will still leave this bug exposed for pages that had already been moved. (I'm marking it as low priority because disabling the title change will make this relatively unimportant.)

This also affects institutions, which can still be moved by renaming.

Reedy subscribed.

Extension is being removed and archived.