Page MenuHomePhabricator

Special:LandingCheck on donate.wikimedia.org without any URL parameters is not working
Closed, ResolvedPublic

Description

Currently, https://donate.wikimedia.org/wiki/Special:LandingCheck returns an error:


LandingCheck

No pages were found while performing the request.

This should not happen. I'm marking this bug as critical, as many pages redirect to this page from https://wikimediafoundation.org/wiki/Special:LandingCheck, including URLs such as https://wikimediafoundation.org/wiki/Fundraising.

First reported at https://meta.wikimedia.org/w/index.php?title=Foundation_wiki_feedback&oldid=4360044#Broken_donate_link_on_error_page by Topbanana.


Version: wmf-deployment
Severity: normal
URL: https://donate.wikimedia.org/wiki/Special:LandingCheck

Details

Reference
bz41566

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:57 AM
bzimport set Reference to bz41566.
bzimport added a subscriber: Unknown Object (MLST).

Redirects to Special pages, according to Toolserver's foundationwiki_p:

mysql> select page_namespace, page_title, rd_title, rd_namespace from redirect join page on rd_from = page_id where rd_namespace = -1\G

  • 1. row *******

page_namespace: 0

  page_title: Comments
    rd_title: ContributionHistory
rd_namespace: -1
  • 2. row *******

page_namespace: 0

  page_title: Donate/Comments/en
    rd_title: ContributionHistory/en
rd_namespace: -1
  • 3. row *******

page_namespace: 0

  page_title: Donate/Comments
    rd_title: ContributionHistory/en
rd_namespace: -1
  • 4. row *******

page_namespace: 0

  page_title: CTS
    rd_title: ContributionTrackingStatistics
rd_namespace: -1
  • 5. row *******

page_namespace: 0

  page_title: Fundraiser_statistics
    rd_title: FundraiserStatistics
rd_namespace: -1
  • 6. row *******

page_namespace: 0

  page_title: Fundraising_statistics
    rd_title: FundraiserStatistics
rd_namespace: -1
  • 7. row *******

page_namespace: 0

  page_title: Fundraising
    rd_title: LandingCheck
rd_namespace: -1
  • 8. row *******

page_namespace: 0

  page_title: Donate
    rd_title: LandingCheck
rd_namespace: -1

8 rows in set (0.00 sec)

Strangely, https://wikimediafoundation.org/wiki/Donate seems to work, but https://wikimediafoundation.org/wiki/Fundraising does not. /Donate seems to be a high-level (Web server-level) redirect. After a bit of further investigation, this bug is probably not critical.

pgehres wrote:

This is not actually a bug in LandingCheck, the link on the error page is
broken. LandingCheck is performing exactly as intended. I submitted a patch a
long time ago, but Ops has ignored it so far

https://gerrit.wikimedia.org/r/#/c/18331/

I've updated the redirect as well:

https://wikimediafoundation.org/w/index.php?title=Fundraising&diff=84815&oldid=76747

I guess we should get this in soon before the season starts.

pgehres wrote:

I'm not too concerned about this getting deployed before the fundraiser since it only comes into play during downtime :-)

Patch got merged on 2013-07-03 11:17. Closing as FIXED.