Page MenuHomePhabricator

Sanity check wikiversions.dat on operations/mediawiki-config
Closed, DeclinedPublic

Description

Not exactly sure where to file this, but whatever.

For the operations/mediawiki-config repo, it'd be useful if we can sanity check wikiversions.dat like sync-wikiversions does

e.g. for errors like this:
reedy@fenari:/home/wikipedia/common$ sync-wikiversions Everything else to 1.21wmf3
Invalid version dir '/home/wikipedia/common/php-1.21wm3' for wiki 'acewiki'.

This is done by using:

reedy@fenari:/home/wikipedia/common$ multiversion/refreshWikiversionsCDB
wikiversions.cdb successfully built.

which is a submodule of mediawiki-config now

Can we have jenkins fail the changeset if we don't get "wikiversions.cdb successfully built."?


Version: unspecified
Severity: enhancement

Details

Reference
bz41861

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:47 AM
bzimport set Reference to bz41861.
bzimport added a subscriber: Unknown Object (MLST).

Some actions:

  • write a PHPUnit test that shell out to refreshWikiversionsCDB
  • make sure refreshWikiversionsCDB returns non 0 exit code on failure, that will fail the build in Jenkins.

We might want to make sure we only have two versions to catch versions typos as highlighted with https://gerrit.wikimedia.org/r/52442

Lowering priority due to these being hard to test. They rely at least on 2 things we don't:

  • /usr/local/apache; /home/wikipedia/common need to exist (hardcoded in the definitions)
  • php-foo and php-bar need to exist
  • more...

Change 105698 had a related patch set uploaded by Hashar:
sanity test for refreshWikiversionsCDB

https://gerrit.wikimedia.org/r/105698

Change 105698 abandoned by Hashar:
sanity test for refreshWikiversionsCDB

Reason:
Not much interest after a few months, so abandoning and will wont fix the bug as well.

https://gerrit.wikimedia.org/r/105698

There was not much interest after a few months, so I abandoned the Gerrit patch and mark this bug as WONTFIX.

Feel free to takeover the original patch and rebase it.