Page MenuHomePhabricator

No width specified to ImageHandler::makeParamString after changing $wgDefaultUserOptions['thumbsize']
Closed, DeclinedPublic

Description

Text displayed

When the image size limits setting in the "User Preferences" are smaller then the actual file (picture) size that is opened in the File: NS an internal error is generated. For example the picture size is 800 x 600px and the size limits setting in the "User Preferences" are set to 640 x 480px the fault is generated.


Version: 1.20.x
Severity: major
OS: Windows Server 2003
Platform: PC
Whiteboard: aklapper-moreinfo

Attached:

Details

Reference
bz41878

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:48 AM
bzimport set Reference to bz41878.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 11331
Example LocalSetting.php

Attached:

After some more testing on a clean MW-1.20.0 installation I found out that this only happens when you want to change the default value for $wgDefaultUserOptions['thumbsize']. An example in the attached localsettings.php.

6 seems a valid value but the fault appears (only when the actual picture size is bigger then the user image size limits in the "User Preferences"). It seems that $wgDefaultUserOptions['thumbsize'] is no longer linked to $wgThumbLimits (as documented) but to $wgImageLimits. Any value bigger than 4 results in the fault, starting with 0 means there are 5 options, in the defaults for $wgImageLimits there are also 5 options.

I am not sure, but looks like this was already fixed with gerrit 47214.

(In reply to Umherirrender from comment #3)

I am not sure, but looks like this was already fixed with Gerrit change
#47214.

jongfeli: Is this still an issue?

(In reply to Andre Klapper from comment #4)

(In reply to Umherirrender from comment #3)

I am not sure, but looks like this was already fixed with Gerrit change
#47214.

jongfeli: Is this still an issue?

Hello Andre. sorry for the late responds. The past few months I had to put more work in the Wiki content and not in the workings :)

I updated our Wiki to 1.22.5 and the issue seems to be gone, I can not reproduce it anymore. Regards, Felipe.

Great that it works for you now!

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM