Page MenuHomePhabricator

TextContent expects a string in the constructor.
Closed, ResolvedPublic

Description

Causing problems during xml dumps: http://p.defau.lt/?7wqGCAZ_YrQa9hEeBMBRTg

2012-11-08 15:59:21 snapshot1 eswiki: [87974a13] [no req] Exception from line 36 of /a/usr/local/apache/common-local/php-1.21wmf3/includes/content/TextContent.php: TextContent expects a string in the constructor.
#0 /a/usr/local/apache/common-local/php-1.21wmf3/includes/content/WikitextContent.php(28): TextContent->construct(false, 'wikitext')
#1 /a/usr/local/apache/common-local/php-1.21wmf3/includes/content/WikitextContentHandler.php(15): WikitextContent->
construct(false)
#2 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Revision.php(1002): WikitextContentHandler->unserializeContent(false, 'text/x-wiki')
#3 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Revision.php(946): Revision->getContentInternal()
#4 /a/usr/local/apache/common-local/php-1.21wmf3/includes/WikiPage.php(616): Revision->getContent(1)
#5 /a/usr/local/apache/common-local/php-1.21wmf3/includes/WikiPage.php(875): WikiPage->getContent()
#6 /a/usr/local/apache/common-local/php-1.21wmf3/includes/WikiPage.php(864): WikiPage->insertRedirect()
#7 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Export.php(600): WikiPage->getRedirectTarget()
#8 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Export.php(441): XmlDumpWriter->openPage(Object(stdClass))
#9 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Export.php(379): WikiExporter->outputPageStream(Object(ResultWrapper))
#10 /a/usr/local/apache/common-local/php-1.21wmf3/includes/Export.php(123): WikiExporter->dumpFrom('')
#11 /a/usr/local/apache/common-local/php-1.21wmf3/maintenance/backup.inc(234): WikiExporter->allPages()
#12 /a/usr/local/apache/common-local/php-1.21wmf3/maintenance/dumpBackup.php(77): BackupDumper->dump(2, 0)
#13 /a/usr/local/apache/common-local/multiversion/MWScript.php(68): require_once('/a/usr/local/ap...')
#14 {main}


Version: unspecified
Severity: major

Details

Reference
bz41900

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:50 AM
bzimport set Reference to bz41900.
bzimport added a subscriber: Unknown Object (MLST).

backup@snapshot1:/backups/dumps/production$ /usr/bin/php -q /apache/common/multiversion/MWScript.php dumpBackup.php --wiki=eswiki --plugin=AbstractFilter:/apache/common/php-1.21wmf3/extensions/ActiveAbstract/AbstractFilter.php --current --report=1000 --force-normal --output=file:/mnt/data/xmldatadumps/public/eswiki/20121108/eswiki-20121108-abstract.xml.testing --filter=namespace:NS_MAIN --filter=noredirect --filter=abstract --start=2355692 --end=2355693
Set $wgShowExceptionDetails = true; in LocalSettings.php to show detailed debugging information.

providing the same start and end (either 2355692 or 2355693) runs successfully. so it's one of those two page ids anyways.

Triggered by a broken revision that can't be retrieved by Revision::getRevisionText().

Caused by Revision::loadContentInternal checking whether text is null, but Revision::getRevisionText() and thus Revision::loadText() return false, not null, upon failure.

Will fix that tomorrow, while cleaning up other places where content may be null or false.

Should be fixed by I551a90b0

Is this still a problem, or can we close this bug?

Ah, I thought it had been closed after that rev went in. Things look good from my end, thanks!

Closed older resolved bugs as verified.