Page MenuHomePhabricator
Create Task
Maniphest T44107

wikieditor-toolbar-help-content-signaturetimestamp-result: Parse error at position 19 in input:
Closed, ResolvedPublic
Actions

Description

Author: rogerchrisman

Description:
Error observed on en.Wikipedia.org on November 14, 2012, time of this posting.

Edit page has a dropdown Edit help feature above the edit field. I think this is a WikiEditor feature called the Magic Bar. In that click the "Edit" drop down item (between "Special characters" and "Cite", towards right end of bar). At left of dropdown frame is now a scrollable selection area. Scroll to bottom of that and click on the item labeled "Discussion" in there. The two examples of signatures there under "What you get" in right column contain, above the expected example, this error message:

wikieditor-toolbar-help-content-signaturetimestamp-result: Parse error at position 19 in input:

Hope this helps. Cheers, Roger

Version: unspecified
Severity: minor
URL: http://en.wikipedia.org/w/index.php?title=Muban&action=edit
See Also:

Details

Reference
bz42107
SubjectRepoBranchLines +/-
Remove non-working {{#special:mypage}} from helpmediawiki/extensions/WikiEditormaster+13 -6
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:05 AM
• bzimport added projects: WikiEditor, JavaScript.
• bzimport set Reference to bz42107.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Nov 14 2012, 6:54 PM
Aklapper added a comment.Nov 16 2012, 2:08 PM

Confirming.

Aklapper added a comment.Nov 16 2012, 2:08 PM

Created attachment 11375
Screenshot

Attached:

42107.png (185×1 px, 25 KB)

Nullzero added a comment.Feb 15 2013, 4:37 AM

It also occurs at Thai Wikipedia.

Aklapper added a comment.Apr 16 2013, 8:04 AM

Still valid.

  1. Be logged in
  2. Go to https://en.wikipedia.org/w/index.php?title=Be_Here_Now_%28album%29&action=edit
  3. Click v Help
  4. Scroll down to "Discussion"
  5. Click it

See under "What you get":

wikieditor-toolbar-help-content-signature-result: Parse error at position 19 in input: Username (talk)

and others.

He7d3r added a comment.EditedAug 31 2013, 3:03 PM

This is not Firefox specific (I can reproduce it on Google Chrome 29.0.1547.62).

I installed the extension in my copy of MW and added the code

if( p === 'wikieditor-toolbar-help-content-signaturetimestamp-result' ){
	console.log( mw.loader.getState( 'mediawiki.jqueryMsg' ) );
}

right before the line return mediaWiki.msg( p ); from the function $.wikiEditor.autoMsg[1]. After reloading the page a few times I noticed the following:

  • Every time mediawiki.jqueryMsg was "ready" the error occurred
  • Every time mediawiki.jqueryMsg was "loaded" there was no error

So, this bug (as well as T54479, and probably the one described on T53321 comment 12) only happens when the module "mediawiki.jqueryMsg" changes the behavior of the function "mediaWiki.msg" (also known as "mw.msg"). This shorthand is used by WikiEditor since 2010 (see r75491#115), but on
Change-Id: I0d220692262356a12e2f1c0ce30cf6f090428332
the format of the shorthand was modified from "plain" (which WikiEditor was using) to "text".

It is likely that using
return mediaWiki.message( p ).plain();
would solve this.

[1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor.git/8981f855a8dfdb3134da18647bb023d1bff3ad7e/modules%2Fjquery.wikiEditor.js#L151

gerritbot added a comment.Aug 31 2013, 3:07 PM

Change 82092 had a related patch set uploaded by Helder.wiki:
Use mediaWiki.message( ... ).plain()

https://gerrit.wikimedia.org/r/82092

gerritbot added a comment.Sep 28 2013, 12:18 PM

Change 82092 merged by jenkins-bot:
Use mediaWiki.message( ... ).plain()

https://gerrit.wikimedia.org/r/82092

He7d3r added a parent task: T19653: Classic edit toolbar & edit tools (tracking).Apr 16 2015, 1:21 PM
He7d3r updated the task description. (Show Details)Dec 21 2015, 11:40 PM
He7d3r set Security to None.
TheDJ reopened this task as Open.Dec 24 2015, 1:20 PM
TheDJ subscribed.

https://gerrit.wikimedia.org/r/113307 probably dealt with this in a more sustainable way, and I think we should revert the above patch with https://gerrit.wikimedia.org/r/#/c/260513/ in order to avoid recurring problems like: T62695: {{SITENAME}} not parsed: "Publish to {{SITENAME}}" as message box title when $wgDefaultUserOptions['wikieditor-publish'] = 1

I notice that this messages

  • wikieditor-toolbar-help-content-signaturetimestamp-result
  • wikieditor-toolbar-help-content-signature-result

Still have non parseable #{{special:mypage}} inside the signature message. These messages should probably be mass replaced and parameterized, just as we have done with the namespaces and the thumb keyword at some point.

gerritbot subscribed.Dec 24 2015, 11:55 PM

Change 260952 had a related patch set uploaded (by TheDJ):
Remove non-working #{{special:mypage}} from help

https://gerrit.wikimedia.org/r/260952

gerritbot added a project: Patch-For-Review.Dec 24 2015, 11:55 PM
gerritbot added a comment.Dec 28 2015, 4:32 AM

Change 260952 merged by jenkins-bot:
Remove non-working {{#special:mypage}} from help

https://gerrit.wikimedia.org/r/260952

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 28 2015, 5:00 AM
TheDJ closed this task as Resolved.Dec 28 2015, 8:23 AM
TheDJ claimed this task.
Catrope unsubscribed.Jan 15 2016, 10:46 PM
GOIII moved this task from Backlog to Closed on the WikiEditor board.Apr 3 2016, 9:48 AM
Jdforrester-WMF removed a parent task: T19653: Classic edit toolbar & edit tools (tracking).May 5 2017, 11:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL