Page MenuHomePhabricator

VisualEditor: Replaced Edit tab should use original label instead of fetching message "edit" msg
Closed, ResolvedPublic

Description

When loading a page with VE enabled, the "edit" tab is changed from the "vector-view-edit" message to the "edit" message. This is apparent on enwiki, where these messages have different values. It's also apparent when using ?uselang=qqx

This shouldn't happen, the message for the edit tab should be consistent.


Version: unspecified
Severity: minor

Details

Reference
bz42117

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:06 AM
bzimport set Reference to bz42117.

Problem is in ViewPageTarget, which assumes that the name of the action and the action's label are the same ('edit' or 'create') or something, per hurried conversation with Trevor. :-)

More widely, we might want our own label for this at first anyway to make it clear which editor people are using during the initial integration - just call it "VisualEditor" and leave the other tab visible next to it?

De-prioritising for December; instead, bug 42221 will take on this need, as discussed with Trevor and Roan.

Change-Id: I2e7dd85cd14049101e2d49751d37797d77bc7c9d

Rephrased summary.

The problem is that different skins use a different message for the Edit button. Vector uses msg key "vector-view-edit". Monobook (and most other skins) use msg key "edit".

By default the messages are equal but on en.wikipedia.org, as example, classic msg "edit" has been changed to contain "Edit this page".

This lead to the tab replacement causing a weird change from "Edit" to "Edit this page" when in VE mode.