Page MenuHomePhabricator

VisualEditor: There is not preview of edit summaries (which are wikitext) - show it in the wikitext diff?
Closed, ResolvedPublic8 Estimated Story Points

Description

The current VisualEditor interface has a "Save page" dialog box with an edit summary input field. However, this edit summary input field accepts wikitext, but has no preview feature for what the rendered wikitext will look like. This is a regression from the standard (non-VisualEditor) interface.

Roan said that there be a mini-editor or mini-parser or something stuck in the edit summary area at some point.

See Also: T62535: VisualEditor: Add a Preview feature to show actual version of page (minus slugs, etc.)

Details

Reference
bz42139

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:07 AM
bzimport set Reference to bz42139.

As Max says, to be resolved by the dialog being a mini-VE surface.

  • Bug 51125 has been marked as a duplicate of this bug. ***

Per bug 51125 (which has been merged into this one), we should show the edit summary if provided in the "Review your changes" tab

User:Elizium23 at en.wp comments that the current save dialog "permits entry of an edit summary with newlines, however, no newlines are preserved in the edit summary when it is saved to the Wiki. This is confusing, because I just used a WYSIWYG editor, but what I see in the edit summary is not what I get."

While, AIUI, the current dialog is only temporary the issue of newlines (and presumably bold, italic, etc) will be applicable to the new "surface" unless that doesn't permit these features or edit summaries are upgraded to support them.

  • Bug 53729 has been marked as a duplicate of this bug. ***

(In reply to comment #1)

As Max says, to be resolved by the dialog being a mini-VE surface.

So this has been assigned to me but I think I need a few pointers. Firstly, where can I find the code for mini-surfaces?

To clarify, when the diff is shown ('Review your changes' dialog pane) we want to parse the entered summary and display it, probably above the diff.

Change 112490 had a related patch set uploaded by Alex Monk:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490

Change 112490 merged by jenkins-bot:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490

Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF set Security to None.