Page MenuHomePhabricator

Reverting to an old version of a video file does not trigger new transcodes
Closed, ResolvedPublic

Description

Reverting a video to an older version ( https://commons.wikimedia.org/w/index.php?title=File%3ATmh.rev.test.ogv&diff=83339659&oldid=83296596 ) breaks the "thumbnails" ( example: https://upload.wikimedia.org/wikipedia/commons/thumb/1/14/Tmh.rev.test.ogv/Tmh.rev.test.ogv.360p.webm ) and does not trigger a new transcode.

Error message:

Error generating thumbnail

The specified thumbnail parameters are not recognized.


Version: master
Severity: normal
URL: https://commons.wikimedia.org/wiki/File:Tmh.rev.test.ogv
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=29179

Details

Reference
bz42294

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:48 AM
bzimport set Reference to bz42294.

jgerber wrote:

looks like the files get purged but are still in the transcode table.

Purging does not trigger new transcodes...

jgerber wrote:

purging is not supposed to trigger new transcodes, people with the right permissiosn can reset transcodes.

in case of a revert the transcodes should be reset. this does not happen currently. not able to test my fix right now since revert is completely broken in my local mediawiki.

Merged gerrit 35151 links here, bug maybe resolved

My test case still does not transcode.

(In reply to comment #4)

Merged Gerrit change #35151 links here, bug maybe resolved

The change got verified twice but as I said, reverting still produces the old behavior.

What does the
if ( $baseID !== false )
mean? Why is it necessary to check if $baseID is true?

jgerber wrote:

the patch is still not deployed on commons, it is deployed on https://test2.wikipedia.org/ now.

Thank you for the info. Seems to work perfectly on test2.wiki.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM