Updater: Database serialization may cause problems, since the connection is not restored on wakeup.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Nov 27 2012, 6:39 PM

Description

Upon running the updater after https://gerrit.wikimedia.org/r/#/c/13855/ was merged, I get:

Purging caches...done.
Database serialization may cause problems, since the connection is not restored on wakeup.
Backtrace:
#0 [internal function]: DatabaseBase->__sleep()
#1 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(412): serialize(Array)
#2 /var/www/wiki/mediawiki/core/includes/installer/DatabaseUpdater.php(361): DatabaseUpdater->setAppliedUpdates('1.21alpha', Array)
#3 /var/www/wiki/mediawiki/core/maintenance/update.php(151): DatabaseUpdater->doUpdates(Array)
#4 /var/www/wiki/mediawiki/core/maintenance/doMaintenance.php(110): UpdateMediaWiki->execute()
#5 /var/www/wiki/mediawiki/core/maintenance/update.php(193): require_once('/var/www/wiki/m...')
#6 {main}

Version: unspecified
Severity: normal

Details

Reference: bz42483

Related Objects

Mentioned Here: rMWc4d0ce485280: Merge changes Idfc2e2b6,I9b30d602

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:01 AM

• bzimport added a project: MediaWiki-Installer.

• bzimport set Reference to bz42483.

Reedy created this task.Nov 27 2012, 6:39 PM

We also get this on our Wikidata test setups, which have all the WMF deployed extensions enabled. Specifically, the abuse filter is a problem. If I disable Abuse Filter, all is good when running update.php

If I enable it, I see the error.

There also is an issue with editing, with Abuse Filter enabled.

[Thu Nov 29 16:40:21 2012] [error] [client 93.220.88.64] PHP Fatal error: Call to a member function setLBInfo() on a non-object in /var/www/common/php-master/includes/db/LoadBalancer.php on line 723,

Although it doesn't seem to matter if I setup an external DB for abusefilter (like central auth, which works perfectly for me), and set the following settings:

$wgAbuseFilterCentralDB = 'abusefilter';                                                        
$wgAbuseFilterIsCentral = true;

If I revert my core code to c4d0ce485280223eda024cc52d37ee19ade02111 (before https://gerrit.wikimedia.org/r/#/c/13855/) then things work fine with update.php and AbuseFilter installed.

(In reply to comment #1)

We also get this on our Wikidata test setups, which have all the WMF deployed
extensions enabled. Specifically, the abuse filter is a problem. If I disable
Abuse Filter, all is good when running update.php

Aha, thanks for narrowing it down.

Backing it out in gerrit change 35923.

dasch wrote:

+1
please force merging the gerrit change
thx

dasch wrote:

Is there maybe a connection to my bug #42637 ?

Gerrit change I96e6dffe should fix this.

(In reply to comment #5)

Is there maybe a connection to my bug #42637 ?

No, not at all.

(In reply to comment #6)

Gerrit change I96e6dffe should fix this.

It's merged. Can this be closed, or does the problem still happen?

Looks fixed to me.

Luke081515 removed a subscriber: • wikibugs-l-list.Jan 28 2016, 6:10 PM

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:10 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM

Updater: Database serialization may cause problems, since the connection is not restored on wakeup.Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Updater: Database serialization may cause problems, since the connection is not restored on wakeup.
Closed, ResolvedPublic
Actions