Page MenuHomePhabricator

Title Blacklist changes are no longer performed in real-time
Closed, ResolvedPublic

Description

It used to be the case that Upload Wizard checked titles against the title blacklist ( https://commons.wikimedia.org/wiki/MediaWiki:Titleblacklist ) as you updated them in the "Describe" step. This check appears to have been broken somewhere along the way. We still have a catch-all check once the user presses "submit", but that's a slower and uglier way of doing things.

It'd be good to restore the original check.

(Tested in Chrome 22. Steps to reproduce: Upload a batch of files and give them titles like DSC03435 - expected behavior, warnings should appear immediately. Actual behavior, warnings only appear once files are submitted.)


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43009

Details

Reference
bz42554

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:06 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz42554.

Unable to reproduce on master, I get the error message 'Please make this title more meaningful.'
However, able to reproduce on commons.

I suspect the problem is explained by the comment in jquery.validate.wmCommonsBlacklist.js

  • These checks are ignored when the TitleBlacklist API is available

confirmed that Title Blacklist is installed on Commons.

first attempt to fix this by checking with the Title Blacklist Api
https://gerrit.wikimedia.org/r/#/c/50953/

https://gerrit.wikimedia.org/r/50953 (Gerrit Change I3cc0f0dd9c6930a98ddfb2657c891150688b05f5) | Patch Set 4:

Would it be terribly difficult to make the checks asynchronous, with a callback chain, and do this properly? I feel like this will block the browser while we check, which seems less than ideal. [by MarkTraceur]

I think this got fixed when we fixed the unrelated titleblacklist problems in https://gerrit.wikimedia.org/r/158337 - working in beta anyway.

Change 50953 abandoned by MarkTraceur:
Test titles in Details step.

Reason:
No longer necessary, bug fixed because of unrelated issue

https://gerrit.wikimedia.org/r/50953

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM