Page MenuHomePhabricator
Create Task
Maniphest T44593

CodeEditor should use ContentHandler
Closed, ResolvedPublic
Actions

Description

The code for this extension predates Daniel K.'s work on ContentHandler in core, and as a result its approach to content-types is archaic and ad-hoc. Rather than check the file extension and then give up, it should instead rely on the interface exposed by ContentHandler and ContentModel classes.

Version: unspecified
Severity: normal

Details

Reference
bz42593

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:09 AM
• bzimport added a project: CodeEditor.
• bzimport set Reference to bz42593.
• bzimport added a subscriber: Unknown Object (MLST).
ori created this task.Dec 1 2012, 5:45 AM
gerritbot added a comment.Dec 31 2013, 10:21 AM

Change 104721 had a related patch set uploaded by TheDJ:
ContentModel: Use CM to choose CE language

https://gerrit.wikimedia.org/r/104721

TheDJ added a comment.Dec 31 2013, 10:22 AM

Slightly related: CM for Scribunto https://bugzilla.wikimedia.org/59160

gerritbot added a comment.Jan 10 2014, 3:43 PM

Change 104721 merged by jenkins-bot:
Use page ContentModel to choose editor language

https://gerrit.wikimedia.org/r/104721

Aklapper added a comment.Mar 11 2014, 5:14 PM

Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL