Page MenuHomePhabricator

deploy to test2 broke UploadWizard in IE7 at least
Closed, ResolvedPublic

Description

IE7 syntax error from UW test2

Automated browser tests failing in some IE7. Attached screen shot is from IE7


Version: unspecified
Severity: minor

Attached:

Screen_shot_2012-12-05_at_1.40.36_PM.png (517×638 px, 58 KB)

Details

Reference
bz42736

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:49 AM
bzimport set Reference to bz42736.
bzimport added a subscriber: Unknown Object (MLST).

although the same version of UW is on test2 and commons, only test2 shows the error, and that happened within the last 24 hours

Lowered priority, this can only be reproduced sporadically on test2 and not on commons.

Not closing, Ryan Kaldari to investigate the possibility of race conditions that could cause this behavior from time to time.

Looks like this is a race condition likely caused by a combination of two things:

  1. wgResourceLoaderExperimentalAsyncLoading being true on test2
  2. UW using old-school JS global var setting rather than mw.config directly

Is this not the same as https://bugzilla.wikimedia.org/show_bug.cgi?id=42922 ?
Both are reported by the same person and have the same attachment.

this seems to be a common effect of deployment

  • This bug has been marked as a duplicate of bug 42922 ***

(In reply to comment #4)

Looks like this is a race condition likely caused by a combination of two
things:

  1. wgResourceLoaderExperimentalAsyncLoading being true on test2
  2. UW using old-school JS global var setting rather than mw.config directly

Can you explain in a bit more detail? I have no idea how to fix this otherwise.

wgResourceLoaderExperimentalAsyncLoading is gone now, so that shouldn't be an issue anymore.