Page MenuHomePhabricator

Javascript error in wd.template when language is set to French
Closed, ResolvedPublic

Description

When loading an item page with language set to French (fr), the loading animation stop and, after a few seconds, the list of sitelinks is showed without edit links.
This issue is caused by a JavaScript exception:
Error: mw.template: Tried to generate invalid HTML for template "wb-aliases-wrapper"

This append on this item: https://www.wikidata.org/wiki/Q752582 but not on this one https://www.wikidata.org/wiki/Q1
This is maybe because this first one has no aliases and the second one has one.

I have also reproduce this bug on my local installation with the trunk of the last Sunday (9th december).


Version: unspecified
Severity: normal

Details

Reference
bz42956

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:04 AM
bzimport set Reference to bz42956.
bzimport added a subscriber: Unknown Object (MLST).

Sorry, I have forgotten to say that this issue append with Firefox 17.0.1 but not with Chrome 24.

Could be a coincidence that this happens to French (fr). It was a problem with s3 as it got a severe replication lag, it could be a timeout due to that.

Going to close this as "worksforme" unless someone finds another item with a similar problem.

Verified in Wikidata demo sprint 26

My guess is that it was just an overloaded web cache server. Loading JS resources in french (and probably selected other languages) timed out.

(In reply to comment #2)

Going to close this as "worksforme" unless someone finds another item with a
similar problem.

WORKSFORME, then.

The issue was real, but it got fixed before I checked the bug and it didn't had any link to gerrit.

Change I641725a2: (bug 42956) Parsing strings passed to template engine.
Change merged.

Sorry, but the bug is still here. See http://www.wikidata.org/wiki/Q869857 for example when connected in French with Firefox 17.0.1.

It was verified on our test and dev system: http://wikidata-test.wikimedia.de/
Fix will be available on wikidata.org with next deployment.

Is it possible to backport and deploy this before the next regular deployment? It makes Wikidata in French unusable and people are asking for a quicker fix than next year.

Update: The fix has been deployed on wikidata.org last night.

Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript