Page MenuHomePhabricator

VisualEditor: Parsoid call on "Review and save" slide hangs for pages with "/"s in them
Closed, ResolvedPublic

Description

[Wikitech-l] Alpha version of the VisualEditor now available on the English Wikipedia

I tried it on enwiki in my sandbox.

It does not work: when I want to "Review and save" a box pops up "Review your changes" --- but nothing happens.

  • MediaWiki 1.21wmf5 (f4a44f9)
  • VisualEditor (Version 0.1.0) (2e6425a)

Version: unspecified
Severity: normal

Details

Reference
bz42988

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:06 AM
bzimport set Reference to bz42988.

IE8 shows errors
Details zum Fehler auf der Webseite

Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C)
Zeitstempel: Wed, 12 Dec 2012 08:18:19 UTC

Meldung: Bezeichner, Zeichenfolge oder Zahl erwartet
Zeile: 5
Zeichen: 746
Code: 0
URI: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cicons-raster%7Cext.visualEditor.viewPageTarget.icons-raster%7Cjquery.multiSuggest%7Crangy&skin=vector&version=20121212T032708Z&*

Not totally sure what's up with the Firefox piece other then see if you can try again a couple minutes later or another page (though your sandbox shouldn't be a problem) so I'll leave that for JamesF and the VE crew ;).

For IE 8, however, it's likely because VE isn't supported in IE8 yet ( per https://en.wikipedia.org/wiki/Wikipedia:VisualEditor#Current_limitations Chrome/Firefox/Safari only). If I remember correctly it's because it actually needs a fair bit of refactoring specifically for IE (and possibly only 9 and 10 and never 8) because it handles things totally differently.

@James

+ works on my User page
+ does not work on User:username/Sandbox page (personal link portlet "Sandbox")

I modified the bug title.

I tried other pages, saw different page formatting when using template {{ok}} and got immediately

+ "Error loading data from server: Unsuccessful request: Error contacting the Parsoid server"

when trying to edit and "Review and save"

VE alpha == not mature yet

(In reply to comment #6)

VE alpha == not mature yet

That's what we've been telling everyone all along. There's a reason we called it an alpha release ;)

Could you link to the page that was failing for you?

Big hype about non working VE...

this page does not work with VE https://en.wikipedia.org/wiki/User:Wikinaut/sandbox

There are going to be lots of things that are broken... that's why it's an experimental alpha release. It works on lots of pages but it still doesn't on lots of others. Personally I'd say the hype is valid but so are the huge cautions of how many things don't work :).

Roan et.al: After some quick experimentation this looks like a possible issues with sub pages in general. The 'hang and not do anything' error that Wikinaut is talking about happens when you're trying to create the subpage (Also experienced it trying to create a subpage in mainspace with the VE). If you try to edit a subpage with VE after it already existed (was created with normal editor) then you get a pop up warning "Error loading data from server: Server error. Would you like to retry?". Trying a couple times on a couple different pages the situation appears to be the same each time.

Tested pages:

User:Jalexander/sandbox
Wikipedia/History?redirect=no
User:Wikinaut/sandbox
Wikipedia/test

I can do screenshots if you need them easily.

This appears to now be fixed, following an update to the Parsoid service yesterday; I can now edit and create articles with "/"s in their title. Closing as fixed.

@James Yes I confirm that it now works for me on my subpage ! Well and quickly fixed.

:-)

Just a note: this affected all page creations, not just subpages. The selective serializer mode did not deal properly with the fetch failure for the original (non-existing) page source.

For completeness: This was fixed in https://gerrit.wikimedia.org/r/38382, because I broke new page creation in the Selective Serializer by not properly handling the error that was raised on not finding page content. Sorry about that folks, there was some turbulence, but we're looking to arrive at our destination ahead of schedule.