Page MenuHomePhabricator

"This title contains some undesirable characters. Please remove them." is not helpful
Closed, ResolvedPublic

Description

screen shot with the error message

  • upload an image
  • at "Describe" step enter "test: test" (without quotes) as image title
  • "This title contains some undesirable characters. Please remove them." error message appears
  • the error message should be more specific about undesirable characters
  • for example, the list of undesirable characters could be added to the error message
  • this bug is similar to Bug 38303 - confusing error message when uploading a file with filename is not allowed.

Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=42554

Attached:

image_title.png (900×1 px, 196 KB)

Details

Reference
bz43009

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:07 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz43009.
bzimport added a subscriber: Unknown Object (MLST).

The number of undesirable characters can be too long to display with the error message, there has to be a better way to describe what is not allowed. Maybe use tipsy?

The error message could then contain only undesirably characters from the title, not the entire list.

I am willing to fix this but not sure if there is an easy way to do it, waiting for some qualified person to comment. Since most of the checking is based on regexes there has to be a message associated with each of the regex used in jquery.validate.wmCommonsBlacklist

Lowering priority as Title Blacklist is supposed to show "higher-quality error messages" and hence wmCommonsBlacklist is likely to be deprecated.

Setting lowest as Title Blacklist is used on Commons so this error message won't appear now.

I would wait for https://gerrit.wikimedia.org/r/#/c/50953/ to get merged and then find a way to use the message provided by TitleBlacklist to show. Hopefully Validate plugin has something for that.

*** This bug has been marked as a duplicate of bug 38303 ***