Page MenuHomePhabricator

VisualEditor: Suppress "Web link" section in link inspector suggestion list if a wiki page link already exists
Closed, InvalidPublic

Description

Present situation: the Visual Editor, when clicking on an existing Wiki-Link, provides the chain-link icon which in turn opens a dialogue which contains a pick list. In the pick list two sections exist: "Existing page" (value e.g. "Pretoria") and "Web link" (e.g. "http://Pretoria").

The present dialogue is good enough for creating new links. However, for existing links it is somewhat confusing to offer a nonsense http:// link as an equally valid alternative to an existing or previously confirmed wiki page.

I suggest to keep the present behaviour for new links, but for existing wiki-page-links suppress the "web link" part of the pick list. It will still be possible to enter URLs directly in the dialogue box, the enhancement is only about suppressing it in the pick list.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=43841

Details

Reference
bz43063

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:11 AM
bzimport set Reference to bz43063.

Not convinced that this is correct; yes, you /can/ have a valid page at a web site, but still want to link to the external one. For the most trivial example, "amazon.com" is both an article (on enwiki) and a valid external link. Therefore I'm minded to WONTFIX this.

Also, I'd note that there are timing issues (as the list is created before the suggestions are returned), but those are minor.

I am not proposing ANY changes to creating a new link. So when you mark the text wikipedia.org, yes you should be provided with page and the url in the picklist.

My suggestion is about the confusion that occurs when the link already exists and already points to an internal page. I believe that then the chance that users want to validly change it to an external http URL are very small and not worth the confusion. The enhancement is about avoiding visual clutter and avoiding accidental mis-selections. And in those cases where you do want to change an external link to an internal one: you can still do it, only not with the pick list.

I am not sure I understand the timing issues you mention, since the web page suggestions are always non-sense suggestions, just prefixing the text with http, so it seems easily suppressible. The ajax responsible for possible pages is a different story, but the visibility of that is not under discussion.

This refers to behaviour that has now changed such that this is no longer actionable, so marking as INVALID.