Page MenuHomePhabricator

CategoryTree git/master does not work with mw 1.20.2 branch
Closed, ResolvedPublic

Description

We fail to get CategoryTree to work with mw 1.20 and see no documentation that a specific older version should be used.

Failing: http://biowikifarm.net/test_v20/Category_Test - this should look like
http://biowikifarm.net/test/Category_Test (the latter still under 1.18.x)

See here for other installed extensions: http://biowikifarm.net/test_v20/Special:Version

This seems to be related to the discussion
http://www.mediawiki.org/wiki/Extension_talk:CategoryTree#no_categories.21_20941
where others seem to have similar problems with mediawiki version later than 1.18.


Version: REL1_20-branch
Severity: critical

Details

Reference
bz43077

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:12 AM
bzimport set Reference to bz43077.

For an example on a WMF wiki, see https://meta.wikimedia.org/wiki/Grants:Index/Requests
(if you do see categories, purge, and they'll disappear).

This may be a simple matter of reverting Gerrit #34493 and Gerrit #36750 . Since these were both Reedy's change, and since that's the only thing that changed in CategoryTree, that seems like a good place to start.

I think it's much more likely just to be boolean fail:

-» » if ( $title === null || $title === '' || $title === false ) {
878 +» » if ( strval( $title ) !== '' ) {