Page MenuHomePhabricator

Mobile edit tagging is hacky
Closed, DeclinedPublic

Description

Currently anything edited via mobile has [Via Mobile] at the end of the edit summary and is not tagged with 'mobile edit'.

Max has written a hack to tag these correctly but this should be mademore formal.


Version: unspecified
Severity: normal

Details

Reference
bz43305

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:59 AM
bzimport set Reference to bz43305.

(Discovered by Erik)

Edits made to articles via lead image upload still don't have the mobile edit tag:

https://en.wikipedia.org/w/index.php?title=Albert_Pitt&diff=prev&oldid=548733374

Is it possible that Erik edited on a page where he had appended useformat=mobile

I just did some experiments on mediawiki:

When I edited
https://mediawiki.org/w/index.php?title=Jdlrobson&useformat=mobile&action=edit

The edit wasn't registered as a mobile edit [1]

However, when I edited via:
https://m.mediawiki.org/w/index.php?title=Jdlrobson&useformat=mobile&action=edit

It was [2].

Thus viewing the mobile site via a desktop url will sometimes not tag an edit with mobile... it seems like a grey area so I'm not sure it should...

[1] https://mediawiki.org/w/index.php?title=Jdlrobson&oldid=674247
[2] https://mediawiki.org/w/index.php?title=Jdlrobson&oldid=674249

Maybe appending useformat=mobile should redirect to the m. domain?

(In reply to comment #4)

Maybe appending useformat=mobile should redirect to the m. domain?

No. We have mobileaction=toggle_view_mobile for that. useformat=mobile has a precise meaning: show this page in a mobile view, even if we're on desktop site. It is for developer use only, not intended to be facing end users in any way, so strangeness can be expected.

Currently, tagging from mobile site works as expected:
https://en.wikipedia.org/w/index.php?title=Albert_Pitt&action=history

And if we look at that tag's description, we see: 'tag-mobile_edit-description' => 'Edit made from mobile site' - from this it can be assumed that the behavior of not tagging edits not coming from m domains is semantically correct.